Bug 231663 - All the SDKVariant.xcconfig files should match
Summary: All the SDKVariant.xcconfig files should match
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-13 01:54 PDT by Myles C. Maxfield
Modified: 2021-10-14 13:31 PDT (History)
19 users (show)

See Also:

Attachments
Patch (1.63 KB, patch)
2021-10-13 01:54 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (26.19 KB, patch)
2021-10-13 19:05 PDT, Myles C. Maxfield 		youennf: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-10-13 01:54:16 PDT 
All the SDKVariant.xcconfig files should match
Comment 1 Myles C. Maxfield 2021-10-13 01:54:43 PDT 
Created attachment 441045 [details]
Patch
Comment 2 Myles C. Maxfield 2021-10-13 19:05:58 PDT 
Created attachment 441176 [details]
Patch
Comment 3 EWS Watchlist 2021-10-13 19:07:06 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 youenn fablet 2021-10-13 23:16:23 PDT 
Comment on attachment 441176 [details]
Patch

LGTM

View in context: https://bugs.webkit.org/attachment.cgi?id=441176&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        The linter says they're all supposed to match.

I do not see the style checker being red in the patch the changes were added (https://bugs.webkit.org/show_bug.cgi?id=225505).
Was the style checker updated after the changes were done?
Comment 5 Myles C. Maxfield 2021-10-14 13:26:35 PDT 
Comment on attachment 441176 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441176&action=review

>> Source/JavaScriptCore/ChangeLog:8
>> +        The linter says they're all supposed to match.
> 
> I do not see the style checker being red in the patch the changes were added (https://bugs.webkit.org/show_bug.cgi?id=225505).
> Was the style checker updated after the changes were done?

Looks like the style check was added in https://trac.webkit.org/changeset/240176/webkit and the libwebrtc changes were added in https://trac.webkit.org/changeset/277176/webkit
Comment 6 Myles C. Maxfield 2021-10-14 13:30:23 PDT 
Committed r284193 (243007@main): <https://commits.webkit.org/243007@main>
Comment 7 Radar WebKit Bug Importer 2021-10-14 13:31:16 PDT 
<rdar://problem/84271698>