Summary: | add test for bug 231353 | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Cameron McCormack (:heycam) <heycam> | ||||||||||
Component: | WebRTC | Assignee: | Cameron McCormack (:heycam) <heycam> | ||||||||||
Status: | NEW --- | ||||||||||||
Severity: | Normal | CC: | eric.carlson, ews-watchlist, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Local Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 229025, 231353 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Cameron McCormack (:heycam)
2021-10-12 16:39:03 PDT
Created attachment 441018 [details]
Patch
(That'll fail EWS since the dependencies haven't landed yet.) Comment on attachment 441018 [details] Patch r=me once bots are happy View in context: https://bugs.webkit.org/attachment.cgi?id=441018&action=review > LayoutTests/webrtc/captureStream-color-space.html:10 > + let srcContext = src.getContext("2d"); Could use const I guess here and below. > LayoutTests/webrtc/captureStream-color-space.html:28 > + assert_array_approx_equals(actual, expected, 2, `actual = ${actual}, expected = ${expected}`); If this fails, we probably never hit t.done(). Maybe 2 is too small. > LayoutTests/webrtc/captureStream-color-space.html:32 > +var t = async_test(function(t) { Could use async_test(async function... > LayoutTests/webrtc/captureStream-color-space.html:45 > + local.createOffer().then(function(desc) { You could write it with await in a more readable way (In reply to youenn fablet from comment #4) > > LayoutTests/webrtc/captureStream-color-space.html:28 > > + assert_array_approx_equals(actual, expected, 2, `actual = ${actual}, expected = ${expected}`); > > If this fails, we probably never hit t.done(). I think the test harness considers a test done when it catches an exception, and we are in a step_func() here. > Maybe 2 is too small. I want it to be just small enough that it passes. We'll see if EWS is OK with it. Created attachment 441701 [details]
Patch for landing
Created attachment 442238 [details]
Patch for EWS
Created attachment 442254 [details]
Patch for EWS
|