Summary: | incoming H.264 video is not correctly color managed | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Cameron McCormack (:heycam) <heycam> | ||||||||||||||
Component: | WebRTC | Assignee: | Cameron McCormack (:heycam) <heycam> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, jer.noble, kkinnunen, philipj, sam, sergio, webkit-bug-importer, youennf | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Local Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 231645, 229025 | ||||||||||||||||
Attachments: |
|
Description
Cameron McCormack (:heycam)
2021-10-07 00:05:57 PDT
Created attachment 440479 [details]
test 1
Created attachment 440480 [details]
test 2
Created attachment 440481 [details]
test 3
Created attachment 440483 [details]
WIP patch
Created attachment 440539 [details]
patch
Comment on attachment 440539 [details]
patch
Let's add a test if possible by adding an Internals API method to grab the color space of webrtc tracks.
You can look at Internals.observeMediaStreamTrack and related.
As of the test, you can write your own WebRTC test or update an existing one, for instance webrtc/video.html
I wanted to use grabNextMediaStreamTrackFrame() and inspect the converted-to-RGB pixel values, but that doesn't seem to be working when the frame is not already RGB. Filed bug 231555 for that. I'll write a test that relies on canvas.drawImage(video), once bug 229025 lands. Created attachment 441028 [details]
Patch for landing
Test in bug 231645. Committed r284082 (242910@main): <https://commits.webkit.org/242910@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441028 [details]. |