| Summary: | Implement missing functions in PrivateClickMeasurementDaemonClient | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=231257 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Alex Christensen
2021-09-30 20:53:08 PDT
Created attachment 439817 [details]
Patch
Created attachment 439867 [details]
Patch
Created attachment 440125 [details]
Patch
Created attachment 440126 [details]
Patch
Created attachment 440127 [details]
Patch
Created attachment 440159 [details]
Patch
Comment on attachment 440159 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440159&action=review > Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementConnection.h:63 > + explicit ConnectionToMachService(CString&& machServiceName, NetworkSession&); Probably don’t need the explicit. > Source/WebKit/Shared/EntryPointUtilities/Cocoa/Daemon/PCMDaemonConnectionSet.mm:47 > + m_connections.set(connection, DebugModeEnabled::No); add() is more efficient and should suffice given that you don’t expect the key to exist. |