Bug 231059

Summary:

[GStreamer] fast/mediastream/video-rotation tests are failing due to missing TestController::takeViewPortSnapshot

Product:

WebKit

Reporter:

Lauro Moura <lmoura>

Component:

Media

Assignee:

Philippe Normand <pnormand>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, hta, jer.noble, menard, philipj, pnormand, sergio, tommyw, vjaquez, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=229792

Attachments:

Description	Flags
Patch	calvaris: review+

Description Lauro Moura 2021-09-30 20:52:48 PDT

fast/mediastream/video-rotation.html
fast/mediastream/video-rotation-gpu-process-crash.html

Added in 242095@main and 242172@main respectively.

Test fails with an empty ErrorEvent raised trying to load a dataURL image from testRunner.takeViewPortSnapshot (new method, only implemented in Cocoa).

Comment 1 Philippe Normand 2021-10-06 04:51:42 PDT

Also, WKPageSetMockCameraOrientation is not implemented for non-cocoa ports...

Comment 2 Philippe Normand 2021-10-18 01:55:02 PDT

Created attachment 441572 [details]
Patch

Comment 3 Xabier Rodríguez Calvar 2021-10-18 02:31:52 PDT

Comment on attachment 441572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441572&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:3013
> +        GST_DEBUG_OBJECT(pad.get(), "No sticky tag event, applying no rotation.");

This message is confusing, since it says you're not applying rotation but you're applying orientation in the end. Or maybe I'm misunderstanding...

Comment 4 Philippe Normand 2021-10-18 03:16:21 PDT

Comment on attachment 441572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441572&action=review

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:3013
>> +        GST_DEBUG_OBJECT(pad.get(), "No sticky tag event, applying no rotation.");
> 
> This message is confusing, since it says you're not applying rotation but you're applying orientation in the end. Or maybe I'm misunderstanding...

Ah yes, bad consequence of the refactor, this was previously in !tagsEvent scope. Nice catch!

Comment 5 Philippe Normand 2021-10-18 06:07:33 PDT

Committed r284368 (243153@main): <https://commits.webkit.org/243153@main>

Comment 6 Radar WebKit Bug Importer 2021-10-18 06:08:18 PDT

<rdar://problem/84367556>