Bug 231059

Summary: [GStreamer] fast/mediastream/video-rotation tests are failing due to missing TestController::takeViewPortSnapshot
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: MediaAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, hta, jer.noble, menard, philipj, pnormand, sergio, tommyw, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=229792
Attachments:
Description Flags
Patch calvaris: review+

Lauro Moura
Reported 2021-09-30 20:52:48 PDT
fast/mediastream/video-rotation.html fast/mediastream/video-rotation-gpu-process-crash.html Added in 242095@main and 242172@main respectively. Test fails with an empty ErrorEvent raised trying to load a dataURL image from testRunner.takeViewPortSnapshot (new method, only implemented in Cocoa).
Attachments
Patch (30.32 KB, patch)
2021-10-18 01:55 PDT, Philippe Normand 		calvaris: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2021-10-06 04:51:42 PDT
Also, WKPageSetMockCameraOrientation is not implemented for non-cocoa ports...
Philippe Normand
Comment 2 2021-10-18 01:55:02 PDT
Created attachment 441572 [details] Patch
Xabier Rodríguez Calvar
Comment 3 2021-10-18 02:31:52 PDT
Comment on attachment 441572 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441572&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:3013 > + GST_DEBUG_OBJECT(pad.get(), "No sticky tag event, applying no rotation."); This message is confusing, since it says you're not applying rotation but you're applying orientation in the end. Or maybe I'm misunderstanding...
Philippe Normand
Comment 4 2021-10-18 03:16:21 PDT
Comment on attachment 441572 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441572&action=review >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:3013 >> + GST_DEBUG_OBJECT(pad.get(), "No sticky tag event, applying no rotation."); > > This message is confusing, since it says you're not applying rotation but you're applying orientation in the end. Or maybe I'm misunderstanding... Ah yes, bad consequence of the refactor, this was previously in !tagsEvent scope. Nice catch!
Philippe Normand
Comment 5 2021-10-18 06:07:33 PDT
Committed r284368 (243153@main): <https://commits.webkit.org/243153@main>
Radar WebKit Bug Importer
Comment 6 2021-10-18 06:08:18 PDT
<rdar://problem/84367556>
Note You need to log in before you can comment on or make changes to this bug.