Bug 231045

Summary: Add SPI to launch a service service worker in a WKWebView and expose service worker to injected bundle
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, benjamin, berto, cgarcia, cmarcelo, esprehn+autocc, ews-watchlist, ggaren, gustavo, japhet, kangil.han, kkinnunen, timothy, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 230649    
Bug Blocks:    
Attachments:
Description Flags
WIP Patch
ews-feeder: commit-queue-
WIP Patch
ews-feeder: commit-queue-
WIP Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2021-09-30 16:28:04 PDT
Add SPI to launch a service service worker in a WKWebView and expose service worker to injected bundle.
Attachments
WIP Patch (122.60 KB, patch)
2021-09-30 16:28 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP Patch (124.26 KB, patch)
2021-09-30 16:46 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP Patch (124.25 KB, patch)
2021-10-01 07:40 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (144.60 KB, patch)
2021-10-01 08:08 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (144.52 KB, patch)
2021-10-01 13:48 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (144.68 KB, patch)
2021-10-04 13:33 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-09-30 16:28:34 PDT
Created attachment 439791 [details] WIP Patch
EWS Watchlist
Comment 2 2021-09-30 16:29:51 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Radar WebKit Bug Importer
Comment 3 2021-09-30 16:44:34 PDT
<rdar://problem/83744069>
Chris Dumez
Comment 4 2021-09-30 16:46:16 PDT
Created attachment 439796 [details] WIP Patch
Chris Dumez
Comment 5 2021-10-01 07:40:57 PDT
Created attachment 439858 [details] WIP Patch
Chris Dumez
Comment 6 2021-10-01 08:08:22 PDT
Created attachment 439862 [details] Patch
Timothy Hatcher
Comment 7 2021-10-01 11:35:57 PDT
Comment on attachment 439862 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439862&action=review > Source/WebCore/page/Page.cpp:3694 > + // FIXME: We currently do not support non-normal worlds in service workers. This will be fine for our needs. > Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h:658 > + WKBundlePageServiceWorkerGlobalObjectIsAvailableForFrameCallback serviceWorkerGlobalObjectIsAvailableForFrame; One space off in the alignment of serviceWorkerGlobalObjectIsAvailableForFrame.
Chris Dumez
Comment 8 2021-10-01 13:48:58 PDT
Created attachment 439904 [details] Patch
Geoffrey Garen
Comment 9 2021-10-04 12:40:26 PDT
Comment on attachment 439904 [details] Patch r=me
EWS
Comment 10 2021-10-04 12:42:48 PDT
Tools/Scripts/svn-apply failed to apply attachment 439904 [details] to trunk. Please resolve the conflicts and upload a new patch.
Chris Dumez
Comment 11 2021-10-04 13:33:37 PDT
Created attachment 440099 [details] Patch
EWS
Comment 12 2021-10-04 16:15:34 PDT
Committed r283522 (242489@main): <https://commits.webkit.org/242489@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440099 [details].
Note You need to log in before you can comment on or make changes to this bug.