Bug 230680

Summary: AX: Split out isInert from isAXHidden on AccessibilityObject
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: AccessibilityAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, koivisto, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 230690    
Bug Blocks: 84635, 165279    
Attachments:
Description Flags
Patch none

Tim Nguyen (:ntim)
Reported 2021-09-23 02:01:10 PDT
Reasons to do this are: * Naming of isAXHidden is a bit of a lie * We don't want to inherit inert state from parent to child, like we do for aria-hidden
Attachments
Patch (5.60 KB, patch)
2021-09-23 02:07 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-09-23 02:01:25 PDT
<rdar://problem/83437885>
Tim Nguyen (:ntim)
Comment 2 2021-09-23 02:07:18 PDT
Created attachment 439027 [details] Patch
EWS
Comment 3 2021-09-23 04:55:02 PDT
Committed r282956 (242046@main): <https://commits.webkit.org/242046@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439027 [details].
Andres Gonzalez
Comment 4 2021-09-23 06:40:45 PDT
(In reply to Tim Nguyen (:ntim) from comment #2) > Created attachment 439027 [details] > Patch Can we add the check for isInert to AccessibilityObject::ignoredFromModalPresence instead? No need to expose isInert in the AXCoreObject interface, so it should be removed from there and from AXIsolatedObject. While you are at it, could you please also remove ignoredFromModalPresence from the AXCoreObject interface and make it a virtual in AccessibilityObject? And also remove it from AXIsolatedObject. Thanks.
Note You need to log in before you can comment on or make changes to this bug.