Bug 230552

Summary: NetworkRTCUDPSocketCocoaConnections should handle NAT64 IP addresses correctly
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, eric.carlson, neo.jung, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
toBefreed fix
ews-feeder: commit-queue-
Fix missing export
none
Patch none

youenn fablet
Reported 2021-09-21 07:06:43 PDT
NetworkRTCUDPSocketCocoaConnections should handle NAT64 IP addresses correctly
Attachments
Patch (4.03 KB, patch)
2021-09-21 07:18 PDT, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (4.33 KB, patch)
2021-09-21 07:46 PDT, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (4.33 KB, patch)
2021-09-21 07:55 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (14.82 KB, patch)
2021-09-21 08:36 PDT, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
toBefreed fix (14.82 KB, patch)
2021-09-21 08:44 PDT, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Fix missing export (17.26 KB, patch)
2021-09-21 09:39 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (17.26 KB, patch)
2021-09-21 10:44 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-09-21 07:07:39 PDT
<rdar://83297256>
youenn fablet
Comment 2 2021-09-21 07:18:08 PDT
Created attachment 438812 [details] Patch
youenn fablet
Comment 3 2021-09-21 07:46:28 PDT
Created attachment 438817 [details] Patch
youenn fablet
Comment 4 2021-09-21 07:55:45 PDT
Created attachment 438818 [details] Patch
Alex Christensen
Comment 5 2021-09-21 08:13:39 PDT
Comment on attachment 438818 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438818&action=review > Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:158 > + std::unique_ptr<struct ifaddrs> toBefreed(interfaces); Capital F > Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:168 > + return nw_nat64_does_interface_index_support_nat64(if_nametoindex(interface->ifa_name)); Documentation says this was only intended for one client. We are not that client. > Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:182 > + return "0.0.0.0"; Why this address?
Alex Christensen
Comment 6 2021-09-21 08:19:50 PDT
Comment on attachment 438818 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438818&action=review > Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:154 > +#if USE(APPLE_INTERNAL_SDK) I think it would be better to add NetworkSPI.h rather than have different behavior like this only in internal builds. That is what our SPI headers are for.
youenn fablet
Comment 7 2021-09-21 08:36:41 PDT
Created attachment 438824 [details] Patch
youenn fablet
Comment 8 2021-09-21 08:44:11 PDT
Created attachment 438826 [details] toBefreed fix
youenn fablet
Comment 9 2021-09-21 09:39:00 PDT
Created attachment 438830 [details] Fix missing export
EWS
Comment 10 2021-09-21 10:14:41 PDT
ChangeLog entry in Source/ThirdParty/libwebrtc/ChangeLog contains OOPS!.
youenn fablet
Comment 11 2021-09-21 10:44:31 PDT
Created attachment 438833 [details] Patch
EWS
Comment 12 2021-09-21 11:30:44 PDT
Committed r282831 (241962@main): <https://commits.webkit.org/241962@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438833 [details].
youenn fablet
Comment 13 2021-10-19 03:22:05 PDT
*** Bug 231733 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.