Bug 230471

Summary: [GPUP] Videos appear black but audio plays normally
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: MediaAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=230500
https://bugs.webkit.org/show_bug.cgi?id=230495
Attachments:
Description Flags
[fast-cq] Patch none

Description Peng Liu 2021-09-19 20:18:58 PDT
Videos appear black but audio plays normally
Comment 1 Peng Liu 2021-09-19 20:33:58 PDT
<rdar://82121369>
Comment 2 Peng Liu 2021-09-19 20:37:48 PDT
Created attachment 438633 [details]
[fast-cq] Patch
Comment 3 youenn fablet 2021-09-20 03:22:20 PDT
Comment on attachment 438633 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438633&action=review

> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:139
> +        destroyContextVideoRenderer();

Can we add a test?
Comment 4 Peng Liu 2021-09-20 13:35:24 PDT
Comment on attachment 438633 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438633&action=review

>> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:139
>> +        destroyContextVideoRenderer();
> 
> Can we add a test?

We don't have a good way to test this for now. Will follow up in bug 230500.
Comment 5 EWS 2021-09-20 13:38:07 PDT
Committed r282774 (241909@main): <https://commits.webkit.org/241909@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438633 [details].