Bug 230320

Summary:

[webkitcorepy] Move FileLock from webkitpy

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dewei_zhu, ews-watchlist, glenn, Hironori.Fujii, slewis, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Jonathan Bedard 2021-09-15 14:40:11 PDT

The mechanics of our webkitpy FileLock are good, but the API is not. Move webkitpy's FileLock into webkitcorepy and clarify the API.

Comment 1 Radar WebKit Bug Importer 2021-09-15 14:40:45 PDT

<rdar://problem/83168826>

Comment 2 Jonathan Bedard 2021-09-15 14:43:04 PDT

Created attachment 438292 [details]
Patch

Comment 3 dewei_zhu 2021-09-20 10:28:54 PDT

Comment on attachment 438292 [details]
Patch

r=me

Comment 4 Jonathan Bedard 2021-09-20 11:31:46 PDT

Created attachment 438703 [details]
Patch for landing

Comment 5 EWS 2021-09-20 12:52:41 PDT

Committed r282770 (241905@main): <https://commits.webkit.org/241905@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438703 [details].

Comment 6 Fujii Hironori 2022-12-19 13:50:32 PST

Comment on attachment 438703 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=438703&action=review

> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/file_lock_unittest.py:95
> +                    self.assertEqual(start_time + 30, int(time.time()))

This check is too strict.
 Bug 249608 – webkitcorepy.tests.file_lock_unittest.FileLockTestCase.test_locked_timeout is randomly failing