Bug 230214

Summary: REGRESSION(r274929): [CoordinatedGraphics] DrawingAreaCoordinatedGraphics::createDisplayRefreshMonitor is no longer used
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, cdumez, clopez, crzwdjk, simon.fraser
Priority: P2 Keywords: Gtk, Regression
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=223648
https://bugs.webkit.org/show_bug.cgi?id=230333
https://bugs.webkit.org/show_bug.cgi?id=230307
https://bugs.webkit.org/show_bug.cgi?id=232745
Attachments:
Description Flags
Patch aperez: review+

Carlos Garcia Campos
Reported 2021-09-13 05:26:52 PDT
That means we use the right display refresh monitor in the threaded compositor but a different one for rendering update scheduler.
Attachments
Patch (1.65 KB, patch)
2021-09-13 05:31 PDT, Carlos Garcia Campos 		aperez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2021-09-13 05:31:05 PDT
Created attachment 438032 [details] Patch
Carlos Garcia Campos
Comment 2 2021-09-14 02:32:36 PDT
Committed r282383 (241645@main): <https://commits.webkit.org/241645@main>
Arcady Goldmints-Orlov
Comment 3 2021-09-14 08:51:07 PDT
This regressed animations/steps-transform-rendering-updates.html: --- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/animations/steps-transform-rendering-updates-expected.txt +++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/animations/steps-transform-rendering-updates-actual.txt @@ -1,5 +1,5 @@ PASS count is 0 -PASS count < 6 is true +FAIL count < 6 should be true. Was false. PASS successfullyParsed is true TEST COMPLETE
Arcady Goldmints-Orlov
Comment 4 2021-09-15 06:57:45 PDT
I opened bug 230307 for the test failure which was apparently not so much caused by this change as unmasked by it.
Carlos Alberto Lopez Perez
Comment 5 2021-09-15 19:35:37 PDT
See also bug 230333 .. seems this may have caused flaky timeouts triggering the test run to stop early (it stops at 50 timeouts/crashes)
Note You need to log in before you can comment on or make changes to this bug.