Bug 229975

Summary:

fast/text/FontFaceSet-status-after-style-update.html is flaky.

Product:

WebKit

Reporter:

Carlos Alberto Lopez Perez <clopez>

Component:

Tools / Tests

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ayumi_kojima, mmaxfield, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=229839

Bug Depends on:

229839, 229844

Bug Blocks:

229850

Attachments:

Description	Flags
Patch	none
Patch	ews-feeder: commit-queue-

Description Carlos Alberto Lopez Perez 2021-09-06 16:47:30 PDT

The test fast/text/FontFaceSet-status-after-style-update.html is flaky since it was added on r282015 
See: https://results.webkit.org/?suite=layout-tests&test=fast%2Ftext%2FFontFaceSet-status-after-style-update.html

When it fails it outputs this diff:

--- /Volumes/Data/worker/bigsur-release-applesilicon-tests-wk2/build/layout-test-results/fast/text/FontFaceSet-status-after-style-update-expected.txt
+++ /Volumes/Data/worker/bigsur-release-applesilicon-tests-wk2/build/layout-test-results/fast/text/FontFaceSet-status-after-style-update-actual.txt
@@ -4,9 +4,10 @@
 
 
 PASS fonts.status is "loaded"
-PASS fonts.status is "loading"
+FAIL fonts.status should be loading. Was loaded.
 PASS fonts.status is "loaded"
 PASS successfullyParsed is true
+Some tests failed.
 
 TEST COMPLETE

Comment 1 Carlos Alberto Lopez Perez 2021-09-06 18:57:01 PDT

Updated expectations on r282071

Comment 2 Myles C. Maxfield 2021-09-07 14:34:45 PDT

Thanks for the test expectations fix. I'll work on this bug this week.

Comment 3 Myles C. Maxfield 2021-09-07 16:20:04 PDT

I'm first seeing if I can reproduce this with run-webkit-tests --child-processes=1 --test-list

Comment 4 Myles C. Maxfield 2021-09-07 23:06:33 PDT

This sequence of tests seems to reproduce the bug 100%:

fast/shapes/shape-outside-floats/shape-outside-clip-path-selection.html
fast/text/FontFaceSet-check-after-style-update.html
fast/text/FontFaceSet-status-after-style-update.html

Comment 5 Myles C. Maxfield 2021-09-07 23:15:43 PDT

This reproduces the problem:

DYLD_FRAMEWORK_PATH=/Users/mmaxfield/Build/Products/Debug ~/Build/Products/Debug/WebKitTestRunner --no-timeout file:///Users/mmaxfield/src/WebKit/OpenSource/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-clip-path-selection.html file:///Users/mmaxfield/src/WebKit/OpenSource/LayoutTests/fast/text/FontFaceSet-check-after-style-update.html file:///Users/mmaxfield/src/WebKit/OpenSource/LayoutTests/fast/text/FontFaceSet-status-after-style-update.html

Comment 6 Myles C. Maxfield 2021-09-07 23:36:28 PDT

Even though we're calling internals.clearMemoryCache(), the CSSFontFaceSource is still coming to us in the Success state.

Comment 7 Myles C. Maxfield 2021-09-07 23:49:35 PDT

Created attachment 437602 [details]
Patch

Comment 8 Myles C. Maxfield 2021-09-07 23:50:37 PDT

Created attachment 437603 [details]
Patch

Comment 9 Myles C. Maxfield 2021-09-07 23:51:02 PDT

I think this counts as test gardening, so I'll just land this if EWS is all green.

Comment 10 EWS 2021-09-08 12:44:13 PDT

Tools/Scripts/svn-apply failed to apply attachment 437603 [details] to trunk.
Please resolve the conflicts and upload a new patch.

Comment 11 Myles C. Maxfield 2021-09-08 12:47:41 PDT

Committed r282163 (241455@main): <https://commits.webkit.org/241455@main>

Comment 12 Radar WebKit Bug Importer 2021-09-08 12:48:17 PDT

<rdar://problem/82886587>

Comment 13 Myles C. Maxfield 2021-09-08 17:40:08 PDT

*** Bug 230062 has been marked as a duplicate of this bug. ***