Bug 229933

Summary: [LFC][Integration] Use inline boxes in run vector for hit testing
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, bfulgham, dpino, lmoura, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=230043
Attachments:
Description Flags
wip
none
patch none

Description Antti Koivisto 2021-09-06 01:06:17 PDT
Simplify hit testing
Comment 1 Antti Koivisto 2021-09-06 01:26:05 PDT
Created attachment 437395 [details]
wip
Comment 2 Antti Koivisto 2021-09-06 06:17:02 PDT
Created attachment 437408 [details]
patch
Comment 3 zalan 2021-09-06 07:45:41 PDT
Comment on attachment 437408 [details]
patch

so much better!
Comment 4 EWS 2021-09-06 10:49:18 PDT
Committed r282060 (241360@main): <https://commits.webkit.org/241360@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437408 [details].
Comment 5 Radar WebKit Bug Importer 2021-09-06 10:50:18 PDT
<rdar://problem/82796806>
Comment 6 Aakash Jain 2021-09-06 15:53:56 PDT
(In reply to EWS from comment #4)
> Committed r282060 (241360@main): <https://commits.webkit.org/241360@main>
This seems to have broken following api-gtk test (as also indicated by EWS): /WebKit2Gtk/TestContextMenu:/webkit/WebKitWebView/default-menu
Comment 7 zalan 2021-09-06 15:59:07 PDT
(In reply to Aakash Jain from comment #6)
> (In reply to EWS from comment #4)
> > Committed r282060 (241360@main): <https://commits.webkit.org/241360@main>
> This seems to have broken following api-gtk test (as also indicated by EWS):
> /WebKit2Gtk/TestContextMenu:/webkit/WebKitWebView/default-menu
this is sus.