| Summary: | FontFaceSet.check() needs to react to style changes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, sam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=230062 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 229850, 229911, 229975 | ||||||||
| Attachments: |
|
||||||||
|
Description
Myles C. Maxfield
2021-09-02 18:52:05 PDT
Created attachment 437232 [details]
Patch
Comment on attachment 437232 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437232&action=review > LayoutTests/fast/text/FontFaceSet-check-after-style-update.html:24 > +document.fonts.values().next().value.load(); This should be just "fonts.values().next().value.load()". Created attachment 437234 [details]
Patch
Comment on attachment 437234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437234&action=review Should we / can we have a font resource that never get's cached (e.g. sets the right headers) to avoid the need to invalidate? > Source/WebCore/css/FontFaceSet.cpp:186 > + auto protect = m_backing; Like the other patch, I would change this to: Ref protect = m_backing; (assuming that compiles). Committed r282016 (241321@main): <https://commits.webkit.org/241321@main> |