Bug 229602

Summary:

[css-position-sticky] createIndicatorForStickyElements testing function races with font loading

Product:

WebKit

Reporter:

Martin Robinson <mrobinson>

Component:

Tools / Tests

Assignee:

Martin Robinson <mrobinson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

clopez, ews-watchlist, Matrixfauly141020, webkit-bug-importer, youennf, zdobersek

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://github.com/web-platform-tests/wpt/pull/30211

Bug Depends on:

Bug Blocks:

203450

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description Martin Robinson 2021-08-27 01:03:18 PDT

The JavaScript function createIndicatorForStickyElements which is used by position: sticky tests measures the size of a div to make an idicator div. The size of the divs that it measures sometimes use web fonts though, so it's possible for the indicator div to be the wrong size if the function executes before web fonts have loaded.

Comment 1 Martin Robinson 2021-08-27 01:06:01 PDT

Created attachment 436612 [details]
Patch

Comment 2 EWS Watchlist 2021-08-27 01:07:38 PDT

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

Comment 3 Martin Robinson 2021-08-27 01:09:52 PDT

Created attachment 436613 [details]
Patch

Comment 4 Martin Robinson 2021-08-27 01:11:30 PDT

Created attachment 436614 [details]
Patch

Comment 5 Martin Robinson 2021-08-27 01:36:27 PDT

Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/30211

Comment 6 Martin Robinson 2021-08-27 09:47:05 PDT

Comment on attachment 436614 [details]
Patch

Thanks for the review!

Comment 7 EWS 2021-08-27 09:50:53 PDT

Committed r281698 (241048@main): <https://commits.webkit.org/241048@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436614 [details].

Comment 8 Radar WebKit Bug Importer 2021-08-27 09:51:44 PDT

<rdar://problem/82442988>

Comment 9 siouszesty fauly 2024-06-04 01:36:36 PDT

The concept of "default playback position" has been around in the spec since October 2011 (https://web.archive.org/web/20111006043825/http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#default-playback-start-position https://backroomsgame.io), but the WebKit implementation isn't aware of it and just resorts to regular seeks in those cases.