Bug 229602

Summary: [css-position-sticky] createIndicatorForStickyElements testing function races with font loading
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: Tools / TestsAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, ews-watchlist, Matrixfauly141020, webkit-bug-importer, youennf, zdobersek
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/web-platform-tests/wpt/pull/30211
Bug Depends on:    
Bug Blocks: 203450    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Martin Robinson
Reported 2021-08-27 01:03:18 PDT
The JavaScript function createIndicatorForStickyElements which is used by position: sticky tests measures the size of a div to make an idicator div. The size of the divs that it measures sometimes use web fonts though, so it's possible for the indicator div to be the wrong size if the function executes before web fonts have loaded.
Attachments
Patch (5.86 KB, patch)
2021-08-27 01:06 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (5.64 KB, patch)
2021-08-27 01:09 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (5.60 KB, patch)
2021-08-27 01:11 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2021-08-27 01:06:01 PDT
Created attachment 436612 [details] Patch
EWS Watchlist
Comment 2 2021-08-27 01:07:38 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Martin Robinson
Comment 3 2021-08-27 01:09:52 PDT
Created attachment 436613 [details] Patch
Martin Robinson
Comment 4 2021-08-27 01:11:30 PDT
Created attachment 436614 [details] Patch
Martin Robinson
Comment 5 2021-08-27 01:36:27 PDT
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/30211
Martin Robinson
Comment 6 2021-08-27 09:47:05 PDT
Comment on attachment 436614 [details] Patch Thanks for the review!
EWS
Comment 7 2021-08-27 09:50:53 PDT
Committed r281698 (241048@main): <https://commits.webkit.org/241048@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436614 [details].
Radar WebKit Bug Importer
Comment 8 2021-08-27 09:51:44 PDT
<rdar://problem/82442988>
Note You need to log in before you can comment on or make changes to this bug.