| Summary: | Cherry-pick ANGLE: Revise WebGL's shaderSource validation | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||||||||
| Component: | ANGLE | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | dino, ews-watchlist, kbr, kkinnunen, kondapallykalyan, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Local Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=229051 | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 223315 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Kimmo Kinnunen
2021-08-10 06:06:11 PDT
Created attachment 435251 [details]
Patch
Created attachment 435254 [details]
Patch
Created attachment 435278 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE Comment on attachment 435278 [details]
Patch
Looks good; verified that WebGLRenderingContextBase is just passing through these shader sources to ANGLE rather than doing any processing like it used to. r+
Created attachment 435324 [details]
Patch for landing
Committed r280904 (240428@main): <https://commits.webkit.org/240428@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435324 [details]. |