| Summary: | Replace webkit- prefix properties with Standard Properties in Source/ | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sonia Singla <soniasingla.1812> | ||||||
| Component: | CSS | Assignee: | Sonia Singla <soniasingla.1812> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | calvaris, dbarton, eric.carlson, esprehn+autocc, ews-watchlist, fred.wang, glenn, gsnedders, gyuyoung.kim, jer.noble, macpherson, menard, obrufau, philipj, sergio, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 228546 | ||||||||
| Attachments: |
|
||||||||
|
Description
Sonia Singla
2021-08-02 03:17:48 PDT
Created attachment 434747 [details]
Patch
Comment on attachment 434747 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434747&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:414 > - -webkit-margin-start: 16px; > + margin-block-start: 16px; You've consistently changed -webkit-margin-start to margin-block-start, but it should be margin-inline-start. I suspect this accounts for all the failures on EWS. Created attachment 434750 [details]
Patch
> You've consistently changed -webkit-margin-start to margin-block-start, but it should be margin-inline-start. I suspect this accounts for all the failures on EWS.
Done, sorry it was done by mistake with find and replace
Committed r280581 (240203@main): <https://commits.webkit.org/240203@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434750 [details]. |