Bug 228697

Summary: Replace webkit- prefix properties with Standard Properties in Source/
Product: WebKit Reporter: Sonia Singla <soniasingla.1812>
Component: CSSAssignee: Sonia Singla <soniasingla.1812>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, dbarton, eric.carlson, esprehn+autocc, ews-watchlist, fred.wang, glenn, gsnedders, gyuyoung.kim, jer.noble, macpherson, menard, obrufau, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 228546    
Attachments:
Description Flags
Patch
none
Patch none

Sonia Singla
Reported 2021-08-02 03:17:48 PDT
Replace webkit- prefix properties with Standard Properties in Source/ directory
Attachments
Patch (11.59 KB, patch)
2021-08-02 05:14 PDT, Sonia Singla 		no flags
DetailsFormatted DiffDiff
Patch (11.61 KB, patch)
2021-08-02 07:46 PDT, Sonia Singla 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sonia Singla
Comment 1 2021-08-02 05:14:17 PDT
Created attachment 434747 [details] Patch
Sam Sneddon [:gsnedders]
Comment 2 2021-08-02 06:24:15 PDT
Comment on attachment 434747 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434747&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:414 > - -webkit-margin-start: 16px; > + margin-block-start: 16px; You've consistently changed -webkit-margin-start to margin-block-start, but it should be margin-inline-start. I suspect this accounts for all the failures on EWS.
Sonia Singla
Comment 3 2021-08-02 07:46:16 PDT
Created attachment 434750 [details] Patch
Sonia Singla
Comment 4 2021-08-02 20:02:46 PDT
> You've consistently changed -webkit-margin-start to margin-block-start, but it should be margin-inline-start. I suspect this accounts for all the failures on EWS. Done, sorry it was done by mistake with find and replace
EWS
Comment 5 2021-08-02 20:37:02 PDT
Committed r280581 (240203@main): <https://commits.webkit.org/240203@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434750 [details].
Radar WebKit Bug Importer
Comment 6 2021-08-02 20:38:19 PDT
<rdar://problem/81442373>
Note You need to log in before you can comment on or make changes to this bug.