Bug 228593

Summary:

[Cocoa|WK1] -[NSAttributeString loadFromHTML...] methods will disable bluetooth route switching

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, ews-watchlist, glenn, jean-yves.avenard, peng.liu6, philipj, sam, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	ews-feeder: commit-queue-
Patch	eric.carlson: review+, ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch for landing	none

Jer Noble

Reported 2021-07-29 10:54:16 PDT

[Cocoa|WK1] -[NSAttributeString loadFromHTML...] methods will disable bluetooth route switching

Attachments
Patch (2.10 KB, patch) 2021-07-29 11:03 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (5.92 KB, patch) 2021-07-29 11:51 PDT, Jer Noble	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (5.92 KB, patch) 2021-07-29 11:57 PDT, Jer Noble	eric.carlson: review+ ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (5.98 KB, patch) 2021-07-29 12:10 PDT, Jer Noble	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (5.99 KB, patch) 2021-07-29 12:39 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2021-07-29 10:54:33 PDT

<rdar://81160969>

Jer Noble

Comment 2 2021-07-29 11:03:06 PDT

Created attachment 434538 [details] Patch

Sam Weinig

Comment 3 2021-07-29 11:05:26 PDT

Comment on attachment 434538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434538&action=review > Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:31 > +#import "DeprecatedGlobalSettings.h" Using DeprecatedGlobalSettings.h from platform/ is a layering violation (DeprecatedGlobalSettings.h is not part of platform/). The pattern to use here is usually to pass the data down from the WebCore layer or via delegation.

Jer Noble

Comment 4 2021-07-29 11:11:37 PDT

(In reply to Sam Weinig from comment #3) > Comment on attachment 434538 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434538&action=review > > > Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:31 > > +#import "DeprecatedGlobalSettings.h" > > Using DeprecatedGlobalSettings.h from platform/ is a layering violation > (DeprecatedGlobalSettings.h is not part of platform/). The pattern to use > here is usually to pass the data down from the WebCore layer or via > delegation. DeprecatedGlobalSettings is used everywhere in platform/. It should probably be moved in there rather than have every use require some kind of delegate push.

Jer Noble

Comment 5 2021-07-29 11:13:13 PDT

(In reply to Jer Noble from comment #4) > (In reply to Sam Weinig from comment #3) > > Comment on attachment 434538 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=434538&action=review > > > > > Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:31 > > > +#import "DeprecatedGlobalSettings.h" > > > > Using DeprecatedGlobalSettings.h from platform/ is a layering violation > > (DeprecatedGlobalSettings.h is not part of platform/). The pattern to use > > here is usually to pass the data down from the WebCore layer or via > > delegation. > > DeprecatedGlobalSettings is used everywhere in platform/. It should probably > be moved in there rather than have every use require some kind of delegate > push. In fact, there are 4 uses outside of platform/, and 18 inside platform/.

Jer Noble

Comment 6 2021-07-29 11:23:01 PDT

Filed bug #228594 to track fixing the layering violation (for this code and all other uses).

Jer Noble

Comment 7 2021-07-29 11:51:06 PDT

Created attachment 434550 [details] Patch

Eric Carlson

Comment 8 2021-07-29 11:57:34 PDT

Comment on attachment 434550 [details] Patch r=me once the bots are happy

Jer Noble

Comment 9 2021-07-29 11:57:44 PDT

Created attachment 434551 [details] Patch

Jer Noble

Comment 10 2021-07-29 12:10:09 PDT

Created attachment 434555 [details] Patch for landing

Jer Noble

Comment 11 2021-07-29 12:39:52 PDT

Created attachment 434558 [details] Patch for landing

EWS

Comment 12 2021-07-29 18:51:25 PDT

Committed r280462 (240097@main): <https://commits.webkit.org/240097@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434558 [details].

Note You need to log in before you can comment on or make changes to this bug.