| Summary: | Location.href setter uses wrong window to resolve relative URLs | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||
| Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | changseok, darin, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, jer.noble, jfernandez, kondapallykalyan, pdr, philipj, rego, sam, sergio, svillar, webkit-bug-importer, ysuzuki, zsun | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| URL: | https://html.spec.whatwg.org/#dom-location-href | ||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=228295 | ||||||||||||||||
| Bug Depends on: | |||||||||||||||||
| Bug Blocks: | 192193 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Chris Dumez
2021-07-26 11:20:16 PDT
Created attachment 434218 [details]
WIP Patch
Created attachment 434232 [details]
WIP Patch
Comment on attachment 434232 [details] WIP Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434232&action=review > LayoutTests/http/tests/dom/window-location-set-href-relative-url-expected.txt:7 > +FAIL popup.location.href should be http://127.0.0.1:8000/dom/resources/square20.jpg. Was http://127.0.0.1:8000/resources/resources/square20.jpg. This test is passing in Chrome and Firefox but failing in WebKit (with either firstWindow or activeWindow for the URL resolution). Created attachment 434236 [details]
Test that shows the bug
This test passes in Chrome and Firefox but fails in WebKit.
Created attachment 434244 [details]
WIP Patch
Created attachment 434251 [details]
Patch
Committed r280333 (239980@main): <https://commits.webkit.org/239980@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434251 [details]. Reopening to attach new patch. Created attachment 434278 [details]
Patch
|
