Bug 228295 - Rename activeWindow to incumbentWindow in the Location class
Summary: Rename activeWindow to incumbentWindow in the Location class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-26 13:10 PDT by Chris Dumez
Modified: 2021-07-26 14:20 PDT (History)
4 users (show)

See Also:

Attachments
Patch (12.67 KB, patch)
2021-07-26 13:11 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (12.67 KB, patch)
2021-07-26 13:15 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-07-26 13:10:33 PDT 
Rename activeWindow to incumbentWindow in the Location class, since this is the naming used both in the HTML specification and Location.idl.
Comment 1 Chris Dumez 2021-07-26 13:11:40 PDT 
Created attachment 434229 [details]
Patch
Comment 2 Darin Adler 2021-07-26 13:14:26 PDT 
Comment on attachment 434229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434229&action=review

> Source/WebCore/page/Location.cpp:284
>      URL completedURL = firstFrame->document()->completeURL(urlString);
> +
> +
>      // FIXME: The specification says to throw a SyntaxError if the URL is not valid.

Not sure why there are two blank lines here.
Comment 3 Chris Dumez 2021-07-26 13:15:26 PDT 
Created attachment 434230 [details]
Patch
Comment 4 EWS 2021-07-26 14:19:26 PDT 
Committed r280313 (239963@main): <https://commits.webkit.org/239963@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434230 [details].
Comment 5 Radar WebKit Bug Importer 2021-07-26 14:20:17 PDT 
<rdar://problem/81129964>