RESOLVED FIXED 228295
Rename activeWindow to incumbentWindow in the Location class 
https://bugs.webkit.org/show_bug.cgi?id=228295
Summary Rename activeWindow to incumbentWindow in the Location class
Chris Dumez
Reported 2021-07-26 13:10:33 PDT
Rename activeWindow to incumbentWindow in the Location class, since this is the naming used both in the HTML specification and Location.idl.
Attachments
Patch (12.67 KB, patch)
2021-07-26 13:11 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (12.67 KB, patch)
2021-07-26 13:15 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-07-26 13:11:40 PDT
Created attachment 434229 [details] Patch
Darin Adler
Comment 2 2021-07-26 13:14:26 PDT
Comment on attachment 434229 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434229&action=review > Source/WebCore/page/Location.cpp:284 > URL completedURL = firstFrame->document()->completeURL(urlString); > + > + > // FIXME: The specification says to throw a SyntaxError if the URL is not valid. Not sure why there are two blank lines here.
Chris Dumez
Comment 3 2021-07-26 13:15:26 PDT
Created attachment 434230 [details] Patch
EWS
Comment 4 2021-07-26 14:19:26 PDT
Committed r280313 (239963@main): <https://commits.webkit.org/239963@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434230 [details].
Radar WebKit Bug Importer
Comment 5 2021-07-26 14:20:17 PDT
<rdar://problem/81129964>
Note You need to log in before you can comment on or make changes to this bug.