Bug 227435
| Summary: | Used of non-existing symbols on Windows | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, eric.carlson, fujii.hironori, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=227250 | ||
Jean-Yves Avenard [:jya]
Seen in bug 227250
When I removed some symbols from PAL/CoreMediaSoftLink.h as they aren't defined on Windows ; it caused a compilation error on the Windows bots:
:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(265,38): error C2065: 'kCMTextMarkupAttribute_ForegroundColorARGB': undeclared identifier [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(277,38): error C2065: 'kCMTextMarkupAttribute_BackgroundColorARGB': undeclared identifier [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKi tBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(289,38): error C2065: 'kCMTextMarkupAttribute_CharacterBackgroundColorARGB': undeclared identifier [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(515,42): error C3861: 'CMFormatDescriptionGetExtensions': identifier not found [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(519,121): error C2065: 'kCMFormatDescriptionExtension_SampleDescriptionExtensionAtoms': undeclared identifier [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Sour ce\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(562,23): error C3861: 'CMSampleBufferGetSampleTimingInfo': identifier not found [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(570,36): error C3861: 'CMSampleBufferGetDataBuffer': identifier not found [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(571,27): error C3861: 'CMBlockBufferGetDataLength': identifier not found [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\ Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(578,5): error C3861: 'CMBlockBufferCopyDataBytes': identifier not found [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(582,25): error C3861: 'CMSampleBufferGetFormatDescription': identifier not found [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
So they are used in code compiled on Windows, but those symbols can't be resolved which would lead to either an assert or a null deref at run time; so either we shouldn't use them at all or they should be added to the Framework (unlikely)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/79849694>
Ahmad Saleem
@Fuji - is this applicable for win-cairo build?
From below, it seems to look like 'AppleWin', I think we can mark this as "RESOLVED CONFIGURATION CHANGED".