Bug 227367 – REGRESSION (r278746): [Mac wk1] media/media-fullscreen-return-to-inline.html is a flaky timeout

• Component: Media
• Status: REOPENED

[Eric Hutchison]

media/media-fullscreen-return-to-inline.html

flaky timeout on Mac wk1 queues. It appears timeout began around r278753. 

History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=media%2Fmedia-fullscreen-return-to-inline.html&test=media%2Fmedia-fullscreen-return-to-inline.html

[Radar WebKit Bug Importer]

<rdar://problem/79733822>

[Eric Hutchison]

Was able to bisect issue to available builds 278743 to 278751.

[Truitt Savell]

Looking at the revisions in this range, it seems like either r278746 or r278747 could have caused this.

Chris or Wenson could you see if one of your changes could be responsible for this regression?

[Wenson Hsieh]

(In reply to Truitt Savell from comment #3)
> Looking at the revisions in this range, it seems like either r278746 or
> r278747 could have caused this.
> 
> Chris or Wenson could you see if one of your changes could be responsible
> for this regression?

It's definitely not r278747, since the codepaths that were changed there aren't compiled on macOS earlier than Monterey.

[Alexey Proskuryakov]

Re-titled based on above comments.

[Eric Hutchison]

Created attachment 432305 [details]
Expectations

[EWS]

Committed r279302 (239178@main): <https://commits.webkit.org/239178@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432305 [details].

[Ryan Haddad]

Reopening since the patch only updated test expectations.

[Chris Dumez]

--- /Volumes/Data/worker/catalina-release-tests-wk1/build/layout-test-results/media/media-fullscreen-return-to-inline-expected.txt
+++ /Volumes/Data/worker/catalina-release-tests-wk1/build/layout-test-results/media/media-fullscreen-return-to-inline-actual.txt
@@ -1,3 +1,4 @@
+FAIL: Timed out waiting for notifyDone to be called
 
 Test that a <video> pauses after exiting fullscreen when the internal property "allowsInlineMediaPlaybackAfterFullscreen" is false.
 
@@ -11,15 +12,6 @@
 EVENT(webkitpresentationmodechanged)
 EXPECTED (internals.isChangingPresentationMode(video) == 'false') OK
 EXPECTED (video.webkitDisplayingFullscreen == 'false') OK
-EXPECTED (video.paused == 'true') OK
+EXPECTED (video.paused == 'true'), OBSERVED 'false' FAIL
 RUN(video.play())
-EVENT(webkitpresentationmodechanged)
-EXPECTED (internals.isChangingPresentationMode(video) == 'false') OK
-EXPECTED (video.webkitDisplayingFullscreen == 'true') OK
-RUN(video.webkitExitFullscreen())
-EVENT(webkitpresentationmodechanged)
-EXPECTED (internals.isChangingPresentationMode(video) == 'false') OK
-EXPECTED (video.webkitDisplayingFullscreen == 'false') OK
-EXPECTED (video.paused == 'false') OK
-END OF TEST

[Chris Dumez]

Sadly, I am having trouble reproducing. I tried both release and debug builds with WK1. I tried running tests sequentially or in parallel.