Bug 226474

Summary: [GTK] fast/text/letter-spacing-produces-nan-width-crash-log.txt crashes with an assertion
Product: WebKit Reporter: Arcady Goldmints-Orlov <crzwdjk>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: bfulgham, dpino, lmoura, mrobinson, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Backtrace
none
Patch
none
Patch
none
Patch none

Arcady Goldmints-Orlov
Reported 2021-05-31 12:52:23 PDT
Created attachment 430210 [details] Backtrace Running the test in a debug build of the GTK minibrowser, there is an assertion tripped: STDERR: ASSERTION FAILED: measuredWidth >= 0 STDERR: ../../Source/WebCore/rendering/ComplexLineLayout.cpp(536) : void WebCore::setLogicalWidthForTextRun(WebCore::RootInlineBox*, WebCore::BidiRun*, WebCore::RenderText&, float, const WebCore::LineInfo&, WebCore::GlyphOverflowAndFallbackFontsMap&, WebCore::VerticalPositionCache&, WebCore::WordMeasurements&) This test was added in bug221628 and intentionally creates a NaN by combining a very large zoom with a letter-spacing of zero. The bugfix fixed this issue for other platforms by replacing a NaN with 0 in certain places but this is apparently not sufficient for GTK.
Attachments
Backtrace (18.17 KB, text/plain)
2021-05-31 12:52 PDT, Arcady Goldmints-Orlov 		no flags
Details
Patch (1.43 KB, patch)
2021-06-01 14:54 PDT, Arcady Goldmints-Orlov 		no flags
DetailsFormatted DiffDiff
Patch (1.46 KB, patch)
2021-06-02 09:53 PDT, Arcady Goldmints-Orlov 		no flags
DetailsFormatted DiffDiff
Patch (1.46 KB, patch)
2021-06-02 10:53 PDT, Arcady Goldmints-Orlov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Arcady Goldmints-Orlov
Comment 1 2021-06-01 14:54:45 PDT
Created attachment 430293 [details] Patch
Arcady Goldmints-Orlov
Comment 2 2021-06-02 09:53:48 PDT
Created attachment 430368 [details] Patch
Arcady Goldmints-Orlov
Comment 3 2021-06-02 10:53:58 PDT
Created attachment 430376 [details] Patch
EWS
Comment 4 2021-06-15 07:12:47 PDT
Committed r278871 (238815@main): <https://commits.webkit.org/238815@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430376 [details].
Radar WebKit Bug Importer
Comment 5 2021-06-15 07:13:27 PDT
<rdar://problem/79341114>
Arcady Goldmints-Orlov
Comment 6 2021-06-15 07:55:42 PDT
Reopening to track the actual fix.
Arcady Goldmints-Orlov
Comment 7 2022-01-17 09:38:51 PST
This has been fixed by r288070 allowing LFC integration to work with the complex text path. *** This bug has been marked as a duplicate of bug 235266 ***
Note You need to log in before you can comment on or make changes to this bug.