| Summary: | [macOS] Support painting data detector highlights inside image overlays | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Component: | Platform | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aestes, bdakin, cdumez, changseok, ddkilzer, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, megan_gardner, mifenton, thorton, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 209788 | ||||||||||
| Bug Blocks: | 226267 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Wenson Hsieh
2021-05-25 10:59:42 PDT
Created attachment 429669 [details]
Patch
Created attachment 429674 [details]
Fix pre-macOS 11 build
Tools/Scripts/svn-apply failed to apply attachment 429674 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Created attachment 429779 [details]
For EWS
Committed r278121 (238171@main): <https://commits.webkit.org/238171@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429779 [details]. (In reply to EWS from comment #5) > Committed r278121 (238171@main): <https://commits.webkit.org/238171@main> > > All reviewed patches have been landed. Closing bug and clearing flags on > attachment 429779 [details]. Follow-up build fix for coverage+release builds due to weak external symbol: REGRESSION (r278121): Fix build failure due to weak external symbol Committed r278461 (278461@main): <https://commits.webkit.org/278461@main> I believe this happened because the weak symbol (DDHighlightCreateWithRectsInVisibleRectWithStyleScaleAndDirection) was added to a second source file: Source/WebCore/page/mac/ImageOverlayControllerMac.mm (In reply to David Kilzer (:ddkilzer) from comment #7) > (In reply to EWS from comment #5) > > Committed r278121 (238171@main): <https://commits.webkit.org/238171@main> > > > > All reviewed patches have been landed. Closing bug and clearing flags on > > attachment 429779 [details]. > > Follow-up build fix for coverage+release builds due to weak external symbol: > > REGRESSION (r278121): Fix build failure due to weak external symbol > > Committed r278461 (278461@main): <https://commits.webkit.org/278461@main> > > I believe this happened because the weak symbol > (DDHighlightCreateWithRectsInVisibleRectWithStyleScaleAndDirection) was > added to a second source file: > > Source/WebCore/page/mac/ImageOverlayControllerMac.mm Ideally, these would be declared a softlinking header in PAL. I can do this refactoring in a followup. (In reply to Wenson Hsieh from comment #8) > (In reply to David Kilzer (:ddkilzer) from comment #7) > > (In reply to EWS from comment #5) > > > Committed r278121 (238171@main): <https://commits.webkit.org/238171@main> > > > > > > All reviewed patches have been landed. Closing bug and clearing flags on > > > attachment 429779 [details]. > > > > Follow-up build fix for coverage+release builds due to weak external symbol: > > > > REGRESSION (r278121): Fix build failure due to weak external symbol > > > > Committed r278461 (278461@main): <https://commits.webkit.org/278461@main> > > > > I believe this happened because the weak symbol > > (DDHighlightCreateWithRectsInVisibleRectWithStyleScaleAndDirection) was > > added to a second source file: > > > > Source/WebCore/page/mac/ImageOverlayControllerMac.mm > > Ideally, these would be declared a softlinking header in PAL. I can do this > refactoring in a followup. Doing this in https://bugs.webkit.org/show_bug.cgi?id=226669. |