Bug 226227

Summary: [macOS] Support painting data detector highlights inside image overlays
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, cdumez, changseok, ddkilzer, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, megan_gardner, mifenton, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 209788    
Bug Blocks: 226267    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Fix pre-macOS 11 build
none
For EWS none

Wenson Hsieh
Reported 2021-05-25 10:59:42 PDT
.
Attachments
Patch (27.45 KB, patch)
2021-05-25 11:58 PDT, Wenson Hsieh 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Fix pre-macOS 11 build (27.77 KB, patch)
2021-05-25 12:15 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
For EWS (26.75 KB, patch)
2021-05-26 11:59 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-05-25 11:58:21 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 2 2021-05-25 12:15:22 PDT
Created attachment 429674 [details] Fix pre-macOS 11 build
EWS
Comment 3 2021-05-26 11:54:07 PDT
Tools/Scripts/svn-apply failed to apply attachment 429674 [details] to trunk. Please resolve the conflicts and upload a new patch.
Wenson Hsieh
Comment 4 2021-05-26 11:59:30 PDT
Created attachment 429779 [details] For EWS
EWS
Comment 5 2021-05-26 13:06:40 PDT
Committed r278121 (238171@main): <https://commits.webkit.org/238171@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429779 [details].
Radar WebKit Bug Importer
Comment 6 2021-05-26 13:07:19 PDT
<rdar://problem/78528218>
David Kilzer (:ddkilzer)
Comment 7 2021-06-04 08:53:41 PDT
(In reply to EWS from comment #5) > Committed r278121 (238171@main): <https://commits.webkit.org/238171@main> > > All reviewed patches have been landed. Closing bug and clearing flags on > attachment 429779 [details]. Follow-up build fix for coverage+release builds due to weak external symbol: REGRESSION (r278121): Fix build failure due to weak external symbol Committed r278461 (278461@main): <https://commits.webkit.org/278461@main> I believe this happened because the weak symbol (DDHighlightCreateWithRectsInVisibleRectWithStyleScaleAndDirection) was added to a second source file: Source/WebCore/page/mac/ImageOverlayControllerMac.mm
Wenson Hsieh
Comment 8 2021-06-04 08:59:58 PDT
(In reply to David Kilzer (:ddkilzer) from comment #7) > (In reply to EWS from comment #5) > > Committed r278121 (238171@main): <https://commits.webkit.org/238171@main> > > > > All reviewed patches have been landed. Closing bug and clearing flags on > > attachment 429779 [details]. > > Follow-up build fix for coverage+release builds due to weak external symbol: > > REGRESSION (r278121): Fix build failure due to weak external symbol > > Committed r278461 (278461@main): <https://commits.webkit.org/278461@main> > > I believe this happened because the weak symbol > (DDHighlightCreateWithRectsInVisibleRectWithStyleScaleAndDirection) was > added to a second source file: > > Source/WebCore/page/mac/ImageOverlayControllerMac.mm Ideally, these would be declared a softlinking header in PAL. I can do this refactoring in a followup.
Wenson Hsieh
Comment 9 2021-06-04 16:34:31 PDT
(In reply to Wenson Hsieh from comment #8) > (In reply to David Kilzer (:ddkilzer) from comment #7) > > (In reply to EWS from comment #5) > > > Committed r278121 (238171@main): <https://commits.webkit.org/238171@main> > > > > > > All reviewed patches have been landed. Closing bug and clearing flags on > > > attachment 429779 [details]. > > > > Follow-up build fix for coverage+release builds due to weak external symbol: > > > > REGRESSION (r278121): Fix build failure due to weak external symbol > > > > Committed r278461 (278461@main): <https://commits.webkit.org/278461@main> > > > > I believe this happened because the weak symbol > > (DDHighlightCreateWithRectsInVisibleRectWithStyleScaleAndDirection) was > > added to a second source file: > > > > Source/WebCore/page/mac/ImageOverlayControllerMac.mm > > Ideally, these would be declared a softlinking header in PAL. I can do this > refactoring in a followup. Doing this in https://bugs.webkit.org/show_bug.cgi?id=226669.
Note You need to log in before you can comment on or make changes to this bug.