Bug 226116

Summary:

Stop using holdLock() in JSC as it is not compatible with Clang thread safety analysis

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

JavaScriptCore

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, saam, sam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=226117
https://bugs.webkit.org/show_bug.cgi?id=226119
https://bugs.webkit.org/show_bug.cgi?id=226127

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2021-05-21 15:36:09 PDT

Stop using holdLock() in JSC as it is not compatible with Clang thread safety analysis (CheckedLock). Use the Locker constructor instead.

Comment 1 Chris Dumez 2021-05-21 15:38:29 PDT

Created attachment 429353 [details]
Patch

Comment 2 Mark Lam 2021-05-21 16:18:34 PDT

Comment on attachment 429353 [details]
Patch

r=me if EWS bots are happy.

Comment 3 EWS 2021-05-21 20:13:26 PDT

Committed r277909 (238042@main): <https://commits.webkit.org/238042@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429353 [details].

Comment 4 Radar WebKit Bug Importer 2021-05-21 20:14:18 PDT

<rdar://problem/78340630>