| Summary: | Remove obsolete media query values | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> | ||||||||
| Component: | CSS | Assignee: | Tim Nguyen (:ntim) <ntim> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | clopez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, koivisto, macpherson, menard, mmaxfield, philipj, sergio, tsavell, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 225402 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Tim Nguyen (:ntim)
2021-05-05 11:45:55 PDT
Also taking care of any-hover: on-demand & hover: on-demand which have been removed too: https://github.com/w3c/csswg-drafts/commit/2078b46218f7462735bb0b5107c9a3e84fb4c4b1 Created attachment 427806 [details]
Patch
In general, we don't remove web-exposed functionality because there's a chance it will break existing content. Do we have any intuition/information about how much breakage to expect as a result of this change? There's no behaviour change in terms of evaluation, before and after the patch, it'll always evaluate as `not all` (e.g. false). Only change is serialization, now that the values are invalid, they'll no longer serialize as specified, but explicitly as `not all`. Serialization is probably the least important bit of media queries, WPT are probably the only case I've seen doing this. Created attachment 427825 [details]
Patch
Created attachment 427852 [details]
Patch
*** Bug 225414 has been marked as a duplicate of this bug. *** Committed r277071 (237374@main): <https://commits.webkit.org/237374@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427852 [details]. The changes in https://trac.webkit.org/changeset/277071/webkit broke imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html on Mac release Macmini8,1 machines Diff: https://build.webkit.org/results/Apple-BigSur-Release-WK2-Tests/r277093%20(2369)/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-diff.txt history: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fmediaqueries%2Ftest_media_queries.html |