Bug 225400

Summary:

Remove obsolete media query values

Product:

WebKit

Reporter:

Tim Nguyen (:ntim) <ntim>

Component:

CSS

Assignee:

Tim Nguyen (:ntim) <ntim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

clopez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, koivisto, macpherson, menard, mmaxfield, philipj, sergio, tsavell, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

225402

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Tim Nguyen (:ntim)

Reported 2021-05-05 11:45:55 PDT

It's redundant with the forced-colors media query which is why it's been removed from the spec. No other browser ships it.

Attachments
Patch (62.31 KB, patch) 2021-05-05 14:18 PDT, Tim Nguyen (:ntim)	no flags	Details Formatted Diff Diff
Patch (66.06 KB, patch) 2021-05-05 17:16 PDT, Tim Nguyen (:ntim)	no flags	Details Formatted Diff Diff
Patch (66.03 KB, patch) 2021-05-05 23:40 PDT, Tim Nguyen (:ntim)	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-05-05 11:50:09 PDT

<rdar://problem/77568034>

Tim Nguyen (:ntim)

Comment 2 2021-05-05 13:44:38 PDT

Also taking care of any-hover: on-demand & hover: on-demand which have been removed too: https://github.com/w3c/csswg-drafts/commit/2078b46218f7462735bb0b5107c9a3e84fb4c4b1

Tim Nguyen (:ntim)

Comment 3 2021-05-05 14:18:29 PDT

Created attachment 427806 [details] Patch

Myles C. Maxfield

Comment 4 2021-05-05 15:31:31 PDT

In general, we don't remove web-exposed functionality because there's a chance it will break existing content. Do we have any intuition/information about how much breakage to expect as a result of this change?

Tim Nguyen (:ntim)

Comment 5 2021-05-05 16:47:05 PDT

There's no behaviour change in terms of evaluation, before and after the patch, it'll always evaluate as `not all` (e.g. false). Only change is serialization, now that the values are invalid, they'll no longer serialize as specified, but explicitly as `not all`. Serialization is probably the least important bit of media queries, WPT are probably the only case I've seen doing this.

Tim Nguyen (:ntim)

Comment 6 2021-05-05 17:16:16 PDT

Created attachment 427825 [details] Patch

Tim Nguyen (:ntim)

Comment 7 2021-05-05 23:40:09 PDT

Created attachment 427852 [details] Patch

Tim Nguyen (:ntim)

Comment 8 2021-05-06 00:19:59 PDT

*** Bug 225414 has been marked as a duplicate of this bug. ***

EWS

Comment 9 2021-05-06 00:36:37 PDT

Committed r277071 (237374@main): <https://commits.webkit.org/237374@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427852 [details].