Bug 225469 - REGRESSION (r277071): imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html is failing
Summary: REGRESSION (r277071): imported/w3c/web-platform-tests/css/mediaqueries/test_m...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-06 11:03 PDT by Truitt Savell
Modified: 2021-05-11 12:03 PDT (History)
13 users (show)

See Also:


Attachments
Patch (90.68 KB, patch)
2021-05-06 23:09 PDT, Tim Nguyen (:ntim)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Radar WebKit Bug Importer 2021-05-06 11:03:30 PDT
<rdar://problem/77616012>
Comment 2 Sam Sneddon [:gsnedders] 2021-05-06 13:13:12 PDT
The subtest name seems to vary here since a recent upstream change to the test by Emilio; filed this upstream at https://github.com/web-platform-tests/wpt/issues/28879 and hopefully Emilio fixes this soon.
Comment 3 Sam Sneddon [:gsnedders] 2021-05-06 15:16:27 PDT
https://github.com/web-platform-tests/wpt/commit/17bf9de651f9f77d8f4f32aeb30da6128b046469 has landed upstream, which stops the subtest names from changing all the time.

Tim, can you reimport the media queries tests following this?
Comment 4 Tim Nguyen (:ntim) 2021-05-06 23:09:55 PDT
Created attachment 427974 [details]
Patch
Comment 5 EWS Watchlist 2021-05-06 23:10:42 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 6 Tim Nguyen (:ntim) 2021-05-06 23:11:05 PDT
Thank you Sam!
Comment 7 Tim Nguyen (:ntim) 2021-05-06 23:11:26 PDT
Committed r277160 (237446@main): <https://commits.webkit.org/237446@main>
Comment 8 Sam Sneddon [:gsnedders] 2021-05-07 06:51:10 PDT
Alas, this still looks bad, albeit now just due to bug 161693.
Comment 9 Truitt Savell 2021-05-07 11:09:17 PDT
Marked this test as failing with https://trac.webkit.org/changeset/277181/webkit
Comment 10 Ryan Haddad 2021-05-11 12:03:14 PDT
Marked as failing for iOS with r277335