Summary: | Enable incremental sweeping of GCAwareJITStubRoutines. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||||
Status: | REOPENED --- | ||||||||||
Severity: | Normal | CC: | annulen, ews-watchlist, fpizlo, gyuyoung.kim, keith_miller, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 227888 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Mark Lam
2021-05-04 17:49:29 PDT
Created attachment 427718 [details]
proposed patch.
Created attachment 427719 [details]
proposed patch.
Comment on attachment 427719 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=427719&action=review > Source/JavaScriptCore/heap/JITStubRoutineSet.h:77 > + WTF::Range<uintptr_t> m_range { 0, 0 }; Qualifying with WTF:: here is only needed because Clang thinks this is ambiguous vs WebCore::Range (despite the "using WTF::Range" above). Created attachment 427721 [details]
proposed patch.
Comment on attachment 427721 [details]
proposed patch.
I think this looks good.
Thanks for the review. Landed in r277027: <http://trac.webkit.org/r277027>. Reverting in https://bugs.webkit.org/show_bug.cgi?id=227888 due to bugs in this patch. Reverted in in r279861: <http://trac.webkit.org/r279861>. |