Bug 225376

Summary: Enable incremental sweeping of GCAwareJITStubRoutines.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: REOPENED ---    
Severity: Normal CC: annulen, ews-watchlist, fpizlo, gyuyoung.kim, keith_miller, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 227888    
Bug Blocks:    
Description Flags
proposed patch.
ews-feeder: commit-queue-
proposed patch.
ews-feeder: commit-queue-
proposed patch. fpizlo: review+

Description Mark Lam 2021-05-04 17:49:29 PDT
This is in preparation for incremental sweeping of CodeBlocks.
Comment 1 Mark Lam 2021-05-04 18:20:28 PDT
Created attachment 427718 [details]
proposed patch.
Comment 2 Mark Lam 2021-05-04 18:26:57 PDT
Created attachment 427719 [details]
proposed patch.
Comment 3 Mark Lam 2021-05-04 18:35:01 PDT
Comment on attachment 427719 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=427719&action=review

> Source/JavaScriptCore/heap/JITStubRoutineSet.h:77
> +    WTF::Range<uintptr_t> m_range { 0, 0 };

Qualifying with WTF:: here is only needed because Clang thinks this is ambiguous vs WebCore::Range (despite the "using WTF::Range" above).
Comment 4 Mark Lam 2021-05-04 18:41:05 PDT
Created attachment 427721 [details]
proposed patch.
Comment 5 Filip Pizlo 2021-05-05 10:18:01 PDT
Comment on attachment 427721 [details]
proposed patch.

I think this looks good.
Comment 6 Mark Lam 2021-05-05 10:28:59 PDT
Thanks for the review.  Landed in r277027: <http://trac.webkit.org/r277027>.
Comment 7 Radar WebKit Bug Importer 2021-05-05 10:29:21 PDT
Comment 8 Mark Lam 2021-07-12 15:14:54 PDT
Reverting in https://bugs.webkit.org/show_bug.cgi?id=227888 due to bugs in this patch.
Comment 9 Mark Lam 2021-07-12 18:51:07 PDT
Reverted in in r279861: <http://trac.webkit.org/r279861>.