Summary: | PerformanceObserver: buffered flag not working in Paint Timing | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nicolas <npm> | ||||||||||
Component: | New Bugs | Assignee: | Noam Rosenthal <noam> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | andrewscheuermann, clopez, eric.carlson, ews-watchlist, glenn, jer.noble, noam, philipj, philip, rik, sergio, simon.fraser, tomac, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | Safari 14 | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 236717 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Nicolas
2021-05-03 07:34:39 PDT
*** Bug 236155 has been marked as a duplicate of this bug. *** Failing test: https://wpt.fyi/results/paint-timing/fcp-only/buffered-flag.window.html?label=experimental&label=master&aligned Created attachment 451507 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess (In reply to EWS Watchlist from comment #5) > This patch modifies the imported WPT tests. Please ensure that any changes > on the tests (not coming from a WPT import) are exported to WPT. Please see > https://trac.webkit.org/wiki/WPTExportProcess https://github.com/web-platform-tests/wpt/pull/32794 Created attachment 451515 [details]
Patch
Comment on attachment 451515 [details]
Patch
Please do the test import in a separate bug.
Created attachment 451675 [details]
Patch
(In reply to Simon Fraser (smfr) from comment #8) > Comment on attachment 451515 [details] > Patch > > Please do the test import in a separate bug. Done, this only includes the relevant test. Comment on attachment 451675 [details]
Patch
If there is an existing test, then import the test first (with a failing result), then land the change. But it would be better to update the entire paint-timing test suite, then make the change.
(In reply to Simon Fraser (smfr) from comment #11) > Comment on attachment 451675 [details] > Patch > > If there is an existing test, then import the test first (with a failing > result), then land the change. But it would be better to update the entire > paint-timing test suite, then make the change. Alrighty. (In reply to Noam Rosenthal from comment #12) > (In reply to Simon Fraser (smfr) from comment #11) > > Comment on attachment 451675 [details] > > Patch > > > > If there is an existing test, then import the test first (with a failing > > result), then land the change. But it would be better to update the entire > > paint-timing test suite, then make the change. > > Alrighty. https://bugs.webkit.org/show_bug.cgi?id=236717 Created attachment 452484 [details]
Patch
Comment on attachment 452484 [details]
Patch
Perfect.
Committed r290247 (?): <https://commits.webkit.org/r290247> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452484 [details]. |