Bug 225162

Summary: Stop building libANGLE.a
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: ANGLEAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, dino, ews-watchlist, graouts, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=218469
https://bugs.webkit.org/show_bug.cgi?id=229080
Attachments:
Description Flags
Patch none

Description Alex Christensen 2021-04-28 13:48:17 PDT 
Stop building libANGLE.a
Comment 1 Alex Christensen 2021-04-28 13:49:41 PDT 
Created attachment 427291 [details]
Patch
Comment 2 Alex Christensen 2021-04-28 13:49:44 PDT 
<rdar://problem/57349384>
Comment 3 EWS Watchlist 2021-04-28 13:50:33 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Alexey Proskuryakov 2021-04-28 14:38:08 PDT 
Comment on attachment 427291 [details]
Patch

I have no idea why this has so many green (added) lines, but rs=me I guess?..
Comment 5 EWS 2021-04-28 14:59:07 PDT 
Committed r276734 (237135@main): <https://commits.webkit.org/237135@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427291 [details].
Comment 6 David Kilzer (:ddkilzer) 2021-04-29 06:43:07 PDT 
(In reply to Alexey Proskuryakov from comment #4)
> Comment on attachment 427291 [details]
> Patch
> 
> I have no idea why this has so many green (added) lines, but rs=me I guess?..

It’s because we were using a trick to link the static library (libANGLE.a) with empty.o to create the dynamic library so we only had to compile the sources once.

When the static library target was removed, the compiled sources had to move from the static library target to the dynamic library target.
Comment 7 David Kilzer (:ddkilzer) 2021-04-29 06:47:47 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #6)
> (In reply to Alexey Proskuryakov from comment #4)
> > Comment on attachment 427291 [details]
> > Patch
> > 
> > I have no idea why this has so many green (added) lines, but rs=me I guess?..
> 
> It’s because we were using a trick to link the static library (libANGLE.a)
> with empty.o to create the dynamic library so we only had to compile the
> sources once.
> 
> When the static library target was removed, the compiled sources had to move
> from the static library target to the dynamic library target.

See:  <https://bugs.webkit.org/show_bug.cgi?id=218469>