Bug 225041

Summary:

Add an option to not enable all experimental features in DumpRenderTree

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

224958

Bug Blocks:

Attachments:

Description	Flags
Adds a flag	none

Description Ryosuke Niwa 2021-04-25 19:11:16 PDT

We need an option to avoid enabling all experimental features in DumpRenderTree
so that we can run tests with the set of features we're intending to ship / are stable.

Comment 1 Ryosuke Niwa 2021-04-25 19:13:12 PDT

Created attachment 427018 [details]
Adds a flag

Comment 2 Wenson Hsieh 2021-04-25 19:15:35 PDT

Comment on attachment 427018 [details]
Adds a flag

View in context: https://bugs.webkit.org/attachment.cgi?id=427018&action=review

r=mews

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:273
> +static int enableAllExperimentalFeatures = YES;

Nit - BOOL?

Comment 3 Ryosuke Niwa 2021-04-25 19:54:42 PDT

Comment on attachment 427018 [details]
Adds a flag

View in context: https://bugs.webkit.org/attachment.cgi?id=427018&action=review

>> Tools/DumpRenderTree/mac/DumpRenderTree.mm:273
>> +static int enableAllExperimentalFeatures = YES;
> 
> Nit - BOOL?

I think getopt_long wants these to be int's, not bool's.

Comment 4 Ryosuke Niwa 2021-04-25 22:51:26 PDT

Comment on attachment 427018 [details]
Adds a flag

Clearing flags on attachment: 427018

Committed r276581 (237017@main): <https://commits.webkit.org/237017@main>

Comment 5 Ryosuke Niwa 2021-04-25 22:51:28 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Radar WebKit Bug Importer 2021-04-25 22:52:19 PDT

<rdar://problem/77138402>