Bug 225041

Summary: Add an option to not enable all experimental features in DumpRenderTree
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 224958    
Bug Blocks:    
Attachments:
Description Flags
Adds a flag none

Ryosuke Niwa
Reported 2021-04-25 19:11:16 PDT
We need an option to avoid enabling all experimental features in DumpRenderTree so that we can run tests with the set of features we're intending to ship / are stable.
Attachments
Adds a flag (2.75 KB, patch)
2021-04-25 19:13 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2021-04-25 19:13:12 PDT
Created attachment 427018 [details] Adds a flag
Wenson Hsieh
Comment 2 2021-04-25 19:15:35 PDT
Comment on attachment 427018 [details] Adds a flag View in context: https://bugs.webkit.org/attachment.cgi?id=427018&action=review r=mews > Tools/DumpRenderTree/mac/DumpRenderTree.mm:273 > +static int enableAllExperimentalFeatures = YES; Nit - BOOL?
Ryosuke Niwa
Comment 3 2021-04-25 19:54:42 PDT
Comment on attachment 427018 [details] Adds a flag View in context: https://bugs.webkit.org/attachment.cgi?id=427018&action=review >> Tools/DumpRenderTree/mac/DumpRenderTree.mm:273 >> +static int enableAllExperimentalFeatures = YES; > > Nit - BOOL? I think getopt_long wants these to be int's, not bool's.
Ryosuke Niwa
Comment 4 2021-04-25 22:51:26 PDT
Comment on attachment 427018 [details] Adds a flag Clearing flags on attachment: 427018 Committed r276581 (237017@main): <https://commits.webkit.org/237017@main>
Ryosuke Niwa
Comment 5 2021-04-25 22:51:28 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2021-04-25 22:52:19 PDT
<rdar://problem/77138402>
Note You need to log in before you can comment on or make changes to this bug.