Bug 224461

Summary: The GPUProcess should only launch when it is needed
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, kkinnunen, peng.liu6, philipj, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224516
Bug Depends on:    
Bug Blocks: 224556    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2021-04-12 16:39:35 PDT
The GPUProcess should only launch when it is needed. This avoids wasting memory on simple pages, especially until we enable "DOM rendering in GPU Process".
Attachments
Patch (29.56 KB, patch)
2021-04-12 16:58 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-04-12 16:58:06 PDT
Created attachment 425811 [details] Patch
EWS
Comment 2 2021-04-13 09:36:44 PDT
Committed r275887 (236452@main): <https://commits.webkit.org/236452@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425811 [details].
Radar WebKit Bug Importer
Comment 3 2021-04-13 09:37:24 PDT
<rdar://problem/76595732>
Peng Liu
Comment 4 2021-04-13 09:53:50 PDT
Comment on attachment 425811 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425811&action=review > Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:271 > + m_enableVP9Decoder = enableVP8Decoder; Not introduced by this patch. Is it a typo here? Probably "m_enableVP8Decoder"?
Chris Dumez
Comment 5 2021-04-13 09:54:36 PDT
Comment on attachment 425811 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425811&action=review >> Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:271 >> + m_enableVP9Decoder = enableVP8Decoder; > > Not introduced by this patch. Is it a typo here? Probably "m_enableVP8Decoder"? Does look like a pre-existing bug. I'll follow-up.
Chris Dumez
Comment 6 2021-04-13 09:59:48 PDT
(In reply to Chris Dumez from comment #5) > Comment on attachment 425811 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=425811&action=review > > >> Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:271 > >> + m_enableVP9Decoder = enableVP8Decoder; > > > > Not introduced by this patch. Is it a typo here? Probably "m_enableVP8Decoder"? > > Does look like a pre-existing bug. I'll follow-up. https://bugs.webkit.org/show_bug.cgi?id=224491
Note You need to log in before you can comment on or make changes to this bug.