Bug 224461 - The GPUProcess should only launch when it is needed
Summary: The GPUProcess should only launch when it is needed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 224556
  Show dependency tree / graph
 
Reported: 2021-04-12 16:39 PDT by Chris Dumez
Modified: 2021-04-14 10:19 PDT (History)
12 users (show)

See Also:

Attachments
Patch (29.56 KB, patch)
2021-04-12 16:58 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-04-12 16:39:35 PDT 
The GPUProcess should only launch when it is needed. This avoids wasting memory on simple pages, especially until we enable "DOM rendering in GPU Process".
Comment 1 Chris Dumez 2021-04-12 16:58:06 PDT 
Created attachment 425811 [details]
Patch
Comment 2 EWS 2021-04-13 09:36:44 PDT 
Committed r275887 (236452@main): <https://commits.webkit.org/236452@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425811 [details].
Comment 3 Radar WebKit Bug Importer 2021-04-13 09:37:24 PDT 
<rdar://problem/76595732>
Comment 4 Peng Liu 2021-04-13 09:53:50 PDT 
Comment on attachment 425811 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425811&action=review

> Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:271
> +    m_enableVP9Decoder = enableVP8Decoder;

Not introduced by this patch. Is it a typo here? Probably "m_enableVP8Decoder"?
Comment 5 Chris Dumez 2021-04-13 09:54:36 PDT 
Comment on attachment 425811 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425811&action=review

>> Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:271
>> +    m_enableVP9Decoder = enableVP8Decoder;
> 
> Not introduced by this patch. Is it a typo here? Probably "m_enableVP8Decoder"?

Does look like a pre-existing bug. I'll follow-up.
Comment 6 Chris Dumez 2021-04-13 09:59:48 PDT 
(In reply to Chris Dumez from comment #5)
> Comment on attachment 425811 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=425811&action=review
> 
> >> Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:271
> >> +    m_enableVP9Decoder = enableVP8Decoder;
> > 
> > Not introduced by this patch. Is it a typo here? Probably "m_enableVP8Decoder"?
> 
> Does look like a pre-existing bug. I'll follow-up.

https://bugs.webkit.org/show_bug.cgi?id=224491