Bug 224491 – Fix typo in GPUProcessConnection::enableVP9Decoders()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Fix typo in GPUProcessConnection::enableVP9Decoders().

[Chris Dumez]

Created attachment 425880 [details]
Patch

[Peng Liu]

Comment on attachment 425880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425880&action=review

> Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:271
> +    m_enableVP8Decoder = enableVP8Decoder;

Thanks for the fix.

By the way, not relevant to this bug, I think we can use a better function name, e.g., enableVPxDecoders(). :-)

[Darin Adler]

Comment on attachment 425880 [details]
Patch

Surprised there is no symptom of this bug. Seems like we might be able to test it.

[Chris Dumez]

(In reply to Darin Adler from comment #3)
> Comment on attachment 425880 [details]
> Patch
> 
> Surprised there is no symptom of this bug. Seems like we might be able to
> test it.

It may well be but I'd appreciate if a media person could take a look at that. I uploaded a fix because the issue was spotted during a review on one of my patch. However, I am not familiar with this code at all.

That said, I think the bug would be fairly subtle since we're sending the correct value over IPC. We're merely caching the wrong value on the connection. I guess the bug would be when changing the setting value. In some cases, it may not take the change into account on GPUProcess side.

[EWS]

Committed r275893 (236458@main): <https://commits.webkit.org/236458@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425880 [details].

[Radar WebKit Bug Importer]

<rdar://problem/76599225>