Bug 224343

Summary: REGRESSION (r275150): set-webkit-configuration is too aggressive at deleting config files when coverage/sanitizer switch is not set
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224009
Bug Depends on: 176131    
Bug Blocks:    
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2021-04-08 15:26:08 PDT
The set-webkit-configuration is too aggressive at deleting config files when coverage/sanitizer switch is not set. This regressed in r275150 for Bug 176131. See also Bug 224009, which fixed the non-coverage/non-sanitizer switches.
Attachments
Patch v1 (3.07 KB, patch)
2021-04-08 15:30 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2021-04-08 15:30:08 PDT
Created attachment 425549 [details] Patch v1
Mark Lam
Comment 2 2021-04-08 15:40:45 PDT
Comment on attachment 425549 [details] Patch v1 r=me
David Kilzer (:ddkilzer)
Comment 3 2021-04-08 16:01:09 PDT
Comment on attachment 425549 [details] Patch v1 Marking cq+ since all build queues have finished building.
EWS
Comment 4 2021-04-08 16:04:53 PDT
Committed r275686 (236320@main): <https://commits.webkit.org/236320@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425549 [details].
Radar WebKit Bug Importer
Comment 5 2021-04-08 16:05:15 PDT
<rdar://problem/76426292>
Note You need to log in before you can comment on or make changes to this bug.