Bug 224321

Summary: PCM: Find a way to validate source_secret_token and source_secret_token_signature
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebCore Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: jiewen_tan, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224885
Bug Depends on:    
Bug Blocks: 221291    
Attachments:
Description Flags
Patch none

Description Jiewen Tan 2021-04-08 03:49:27 PDT
Find a way to validate source_secret_token and source_secret_token_signature.
Comment 1 Radar WebKit Bug Importer 2021-04-15 03:50:13 PDT
<rdar://problem/76695542>
Comment 2 Jiewen Tan 2021-05-04 13:49:51 PDT
Created attachment 427695 [details]
Patch
Comment 3 John Wilander 2021-05-04 17:28:16 PDT
Comment on attachment 427695 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427695&action=review

r=me

> Source/WebKit/ChangeLog:9
> +        Covered by exisiting tests.

Not really. This is expanding the test. :) No big deal though.
Comment 4 Jiewen Tan 2021-05-04 17:32:30 PDT
Comment on attachment 427695 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427695&action=review

Thanks John for r+ this patch.

>> Source/WebKit/ChangeLog:9
>> +        Covered by exisiting tests.
> 
> Not really. This is expanding the test. :) No big deal though.

Well, the change in WebKit specifically is covered by existing tests. : )
Comment 5 EWS 2021-05-04 17:42:23 PDT
Committed r276998 (237318@main): <https://commits.webkit.org/237318@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427695 [details].