| Summary: | Enable QuotaExceededError on non GSTREAMER platforms | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||
| Component: | Media | Assignee: | Saam Barati <saam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, calvaris, eric.carlson, ews-watchlist, glenn, jer.noble, keith_miller, mark.lam, peng.liu6, philipj, sergio, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 224139 | ||||||||
| Attachments: |
|
||||||||
|
Description
Saam Barati
2021-04-02 15:30:27 PDT
Created attachment 425061 [details]
patch
Created attachment 425072 [details]
patch for landing
Comment on attachment 425072 [details] patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=425072&action=review > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:-500 > -#endif Oh, wow! Did we audit other GSTREAMER-only code to make sure nothing else was missed? Comment on attachment 425072 [details] patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=425072&action=review >> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:-500 >> -#endif > > Oh, wow! Did we audit other GSTREAMER-only code to make sure nothing else was missed? I haven't. Probably best for someone who truly understands the media code to do this. Also, this change isn't sufficient for media in gpu process. That'll be done by Peng in: https://bugs.webkit.org/show_bug.cgi?id=224139 Committed r275466: <https://commits.webkit.org/r275466> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425072 [details]. Comment on attachment 425072 [details] patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=425072&action=review >>> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:-500 >>> -#endif >> >> Oh, wow! Did we audit other GSTREAMER-only code to make sure nothing else was missed? > > I haven't. Probably best for someone who truly understands the media code to do this. > > Also, this change isn't sufficient for media in gpu process. That'll be done by Peng in: > https://bugs.webkit.org/show_bug.cgi?id=224139 By the way, the code is GStreamer port only because some sites did not work well if we enable the exception, and it was the only one case in the current MSE implementation as far as I know. |