Bug 224136

Summary: Enable QuotaExceededError on non GSTREAMER platforms
Product: WebKit Reporter: Saam Barati <saam>
Component: MediaAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, calvaris, eric.carlson, ews-watchlist, glenn, jer.noble, keith_miller, mark.lam, peng.liu6, philipj, sergio, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 224139    
Attachments:
Description Flags
patch
jer.noble: review+, ews-feeder: commit-queue-
patch for landing none

Saam Barati
Reported 2021-04-02 15:30:27 PDT
...
Attachments
patch (1.87 KB, patch)
2021-04-02 15:35 PDT, Saam Barati 		jer.noble: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch for landing (3.46 KB, patch)
2021-04-02 18:09 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2021-04-02 15:31:06 PDT
<rdar://71219720>
Saam Barati
Comment 2 2021-04-02 15:35:57 PDT
Created attachment 425061 [details] patch
Saam Barati
Comment 3 2021-04-02 18:09:19 PDT
Created attachment 425072 [details] patch for landing
Brent Fulgham
Comment 4 2021-04-05 10:03:28 PDT
Comment on attachment 425072 [details] patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=425072&action=review > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:-500 > -#endif Oh, wow! Did we audit other GSTREAMER-only code to make sure nothing else was missed?
Saam Barati
Comment 5 2021-04-05 11:19:29 PDT
Comment on attachment 425072 [details] patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=425072&action=review >> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:-500 >> -#endif > > Oh, wow! Did we audit other GSTREAMER-only code to make sure nothing else was missed? I haven't. Probably best for someone who truly understands the media code to do this. Also, this change isn't sufficient for media in gpu process. That'll be done by Peng in: https://bugs.webkit.org/show_bug.cgi?id=224139
EWS
Comment 6 2021-04-05 18:06:27 PDT
Committed r275466: <https://commits.webkit.org/r275466> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425072 [details].
Peng Liu
Comment 7 2021-04-06 10:51:20 PDT
Comment on attachment 425072 [details] patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=425072&action=review >>> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:-500 >>> -#endif >> >> Oh, wow! Did we audit other GSTREAMER-only code to make sure nothing else was missed? > > I haven't. Probably best for someone who truly understands the media code to do this. > > Also, this change isn't sufficient for media in gpu process. That'll be done by Peng in: > https://bugs.webkit.org/show_bug.cgi?id=224139 By the way, the code is GStreamer port only because some sites did not work well if we enable the exception, and it was the only one case in the current MSE implementation as far as I know.
Note You need to log in before you can comment on or make changes to this bug.