Bug 224056

Summary: Share same code between network process termination and crash handling
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, darin, ggaren, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224022
Attachments:
Description Flags
Patch none

Description Chris Dumez 2021-04-01 10:25:17 PDT 
Share same code between network process termination and crash handling. This would avoid bugs such as Bug 224022.
Comment 1 Chris Dumez 2021-04-01 10:30:03 PDT 
Created attachment 424911 [details]
Patch
Comment 2 Alex Christensen 2021-04-01 11:59:17 PDT 
Comment on attachment 424911 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424911&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:-1745
> -        processPool->terminateServiceWorkers();

Does this have a replacement?
Comment 3 Chris Dumez 2021-04-01 12:01:06 PDT 
Comment on attachment 424911 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424911&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:484
>          m_automationSession->terminate();

Yes, networkProcessDidTerminate() gets called on termination now and terminates the service workers 2 lines below here.
Comment 4 EWS 2021-04-01 15:27:25 PDT 
Committed r275389: <https://commits.webkit.org/r275389>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424911 [details].
Comment 5 Radar WebKit Bug Importer 2021-04-01 15:28:14 PDT 
<rdar://problem/76124951>