Bug 224022

Summary: REGRESSION: The NetworkProcess sometimes fails to relaunch after it crashes
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, darin, ggaren, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224024
https://bugs.webkit.org/show_bug.cgi?id=224056
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2021-03-31 15:09:33 PDT
The NetworkProcess fails to relaunch after it crashes. This is a regression from using a NetworkProcess per ProcessPool to a NetworkProcess per WebsiteDataStore AFAICT.
Attachments
Patch (2.09 KB, patch)
2021-03-31 15:15 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-03-31 15:09:52 PDT
<rdar://75148724>
Chris Dumez
Comment 2 2021-03-31 15:15:12 PDT
Created attachment 424827 [details] Patch
Alex Christensen
Comment 3 2021-03-31 15:22:55 PDT
Comment on attachment 424827 [details] Patch didTerminate does this too.
Chris Dumez
Comment 4 2021-03-31 15:25:27 PDT
(In reply to Alex Christensen from comment #3) > Comment on attachment 424827 [details] > Patch > > didTerminate does this too. Indeed, I think the termination and crash logic should share code. I opted not to do it in this patch so to keep the patch small as possible for cherry-picking. Also, there are things the crash handling does and that the termination handling doesn't, which seems like another issue.
Chris Dumez
Comment 5 2021-03-31 15:28:42 PDT
Comment on attachment 424827 [details] Patch I will work in a follow-up to share more code between the termination and crash logic.
EWS
Comment 6 2021-03-31 16:19:54 PDT
Committed r275316: <https://commits.webkit.org/r275316> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424827 [details].
Note You need to log in before you can comment on or make changes to this bug.