Bug 224009

Summary: REGRESSION (r275150): set-webkit-configuration is too aggressive at deleting config files when switch is not set
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224343
Bug Depends on: 176131    
Bug Blocks:    
Attachments:
Description Flags
Patch v1 ews-feeder: commit-queue-

David Kilzer (:ddkilzer)
Reported 2021-03-31 12:23:22 PDT
The set-webkit-configuration is too aggressive at deleting config files when switch is not set. This regressed in r275150 for Bug 176131.
Attachments
Patch v1 (2.72 KB, patch)
2021-03-31 12:28 PDT, David Kilzer (:ddkilzer) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2021-03-31 12:28:08 PDT
Created attachment 424799 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 2 2021-03-31 12:42:52 PDT
Comment on attachment 424799 [details] Patch v1 Marking cq+ because enough builds have succeeded that I don't think I made the situation any worse, and I want to get this landed sooner rather than later. (I also compared this patch to set-webkit-configuration from r275150 and the subroutines I restored were unchanged as expected.)
EWS
Comment 3 2021-03-31 13:36:16 PDT
Committed r275305: <https://commits.webkit.org/r275305> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424799 [details].
Radar WebKit Bug Importer
Comment 4 2021-03-31 13:37:13 PDT
<rdar://problem/76068475>
Note You need to log in before you can comment on or make changes to this bug.