Bug 223475

Summary: [LayoutTests] Convert http/tests/multipart convert PHP to Python
Product: WebKit Reporter: Chris Gambrell <cgambrell>
Component: Tools / TestsAssignee: Chris Gambrell <cgambrell>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, ews-watchlist, hi, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220749
https://bugs.webkit.org/show_bug.cgi?id=263425
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Gambrell
Reported 2021-03-18 13:23:20 PDT
Replacing PHP with equivalent Python CGI scripts
Attachments
Patch (19.40 KB, patch)
2021-03-18 13:31 PDT, Chris Gambrell 		no flags
DetailsFormatted DiffDiff
Patch (19.29 KB, patch)
2021-03-22 13:24 PDT, Chris Gambrell 		no flags
DetailsFormatted DiffDiff
Patch (7.49 KB, patch)
2021-04-01 22:29 PDT, Chris Gambrell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-18 13:23:43 PDT
<rdar://problem/75587716>
Chris Gambrell
Comment 2 2021-03-18 13:31:34 PDT
Created attachment 423643 [details] Patch
Jonathan Bedard
Comment 3 2021-03-22 09:39:12 PDT
Comment on attachment 423643 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423643&action=review > LayoutTests/http/tests/multipart/multipart-html.py:13 > + '{}\n' You used f-strings in another patch, might be a good choice here too > LayoutTests/http/tests/multipart/multipart-replace-non-html-content.py:13 > + '{}\n' Might consider f-string here as well
Chris Gambrell
Comment 4 2021-03-22 13:24:48 PDT
Created attachment 423925 [details] Patch
Chris Gambrell
Comment 5 2021-03-22 13:26:49 PDT
(In reply to Jonathan Bedard from comment #3) > Comment on attachment 423643 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=423643&action=review > > > LayoutTests/http/tests/multipart/multipart-html.py:13 > > + '{}\n' > > You used f-strings in another patch, might be a good choice here too > > > LayoutTests/http/tests/multipart/multipart-replace-non-html-content.py:13 > > + '{}\n' > > Might consider f-string here as well Fixed in comment 4
EWS
Comment 6 2021-03-22 14:54:34 PDT
Committed r274803: <https://commits.webkit.org/r274803> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423925 [details].
Chris Gambrell
Comment 7 2021-04-01 22:27:35 PDT
Reopening for second pass
Chris Gambrell
Comment 8 2021-04-01 22:29:58 PDT
Created attachment 424989 [details] Patch
Alex Christensen
Comment 9 2021-04-02 09:24:10 PDT
Comment on attachment 424989 [details] Patch r=me, assuming python works in seconds and php works in microseconds so * 1000000 is no longer needed.
EWS
Comment 10 2021-04-02 10:01:10 PDT
Committed r275424: <https://commits.webkit.org/r275424> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424989 [details].
Note You need to log in before you can comment on or make changes to this bug.