Bug 222865

Summary: Add preference reseting to WebKitLegacy Windows to simplify testing reset
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, fujii.hironori, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sam Weinig
Reported 2021-03-06 10:29:16 PST
Add preference reseting to WebKitLegacy Windows to simplify testing reset
Attachments
Patch (4.09 KB, patch)
2021-03-06 10:42 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2021-03-06 10:42:02 PST
Created attachment 422499 [details] Patch
Sam Weinig
Comment 2 2021-03-07 09:52:47 PST
Not sure if we have a bug about it already, but filed https://bugs.webkit.org/show_bug.cgi?id=222887 about the clean build issue.
Brent Fulgham
Comment 3 2021-03-08 09:43:24 PST
Comment on attachment 422499 [details] Patch This change looks correct, but the build system doesn't seem to be picking up the revised header.
Sam Weinig
Comment 4 2021-03-08 14:44:04 PST
Comment on attachment 422499 [details] Patch Tim told me to just land this, so I am.
EWS
Comment 5 2021-03-08 14:47:25 PST
Committed r274111: <https://commits.webkit.org/r274111> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422499 [details].
Radar WebKit Bug Importer
Comment 6 2021-03-08 14:48:15 PST
<rdar://problem/75188632>
Fujii Hironori
Comment 7 2021-03-11 23:31:17 PST
Filed: Bug 223109 – [Win][WK1] Some JS tests are timing out for Debug build since r274111
Note You need to log in before you can comment on or make changes to this bug.