Bug 222672 – [ews] Add python 3 support - part 4

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Aakash Jain]

Add Python 3 support to ews code, specifically to events.py

[Radar WebKit Bug Importer]

<rdar://problem/74995373>

[Aakash Jain]

Created attachment 422130 [details]
Patch

[Aakash Jain]

Created attachment 422131 [details]
Patch

[Aakash Jain]

Comment on attachment 422131 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422131&action=review

> Tools/CISupport/ews-build/events.py:37
> +from zope.interface import implementer

Using implementer instead of implements to prevent the error:
"builtins.TypeError: Class advice impossible in Python3. Use the @implementer class decorator instead"

> Tools/CISupport/ews-build/events.py:48
> +            self.body = json.dumps(data, default=self.json_serialize_datetime).encode('utf-8')

This is to prevent the error:
Failure: twisted.web._newclient.RequestGenerationFailed: [<twisted.python.failure.Failure builtins.TypeError: Must write bytes to a TLS transport, not unicode.>]

> Tools/CISupport/ews-build/events.py:76
> +    EVENT_SERVER_ENDPOINT = b'https://ews.webkit.org/results/'

This is to prevent the error:
	  File "/usr/local/lib64/python3.6/site-packages/twisted/web/_newclient.py", line 646, in _ensureValidURI
	    if _VALID_URI.match(uri):
	builtins.TypeError: cannot use a bytes pattern on a string-like object

> Tools/CISupport/ews-build/events.py:98
> +        agent.request(b'POST', self.EVENT_SERVER_ENDPOINT, Headers({'Content-Type': ['application/json']}), body)

This is to prevent the error:

  File "/usr/local/lib64/python3.6/site-packages/twisted/web/client.py", line 1507, in _requestWithEndpoint
TypeError: method='POST' is <class 'str'>, but must be bytes

[Aakash Jain]

Tested this patch on ews uat instance for both buildbot v1.8.2 and buildbot v2.10.1, by re-installing those buildbot versions (one by one) and running few builds to ensure that the data is sent and received properly.

[EWS]

Committed r273838: <https://commits.webkit.org/r273838>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422131 [details].