RESOLVED FIXED 222744
[ews] Add python 3 support - part 5 
https://bugs.webkit.org/show_bug.cgi?id=222744
Summary [ews] Add python 3 support - part 5
Aakash Jain
Reported 2021-03-04 09:44:11 PST
Add Python 3 support to ews code (to make it compatible with both Python 2 and 3).
Attachments
Patch (2.40 KB, patch)
2021-03-04 10:14 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2021-03-04 10:14:06 PST
Created attachment 422252 [details] Patch
Aakash Jain
Comment 2 2021-03-04 10:17:10 PST
This patch fixes the exception encountered in: https://ews-build.webkit-uat.org/#/builders/1/builds/1191 File "/var/buildbot/OpenSource/Tools/CISupport/ews-build/steps.py", line 409, in _patch_is_relevant if re.search(path, change, re.IGNORECASE): builtins.TypeError: cannot use a string pattern on a bytes-like object In python 3, buildbot stores the patch as 'bytes'. See: https://github.com/buildbot/buildbot/issues/5812#issuecomment-790175979. So, we should ensure that the search pattern is also bytes.
EWS
Comment 3 2021-03-04 12:42:57 PST
Committed r273913: <https://commits.webkit.org/r273913> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422252 [details].
Radar WebKit Bug Importer
Comment 4 2021-03-04 12:43:18 PST
<rdar://problem/75052319>
Note You need to log in before you can comment on or make changes to this bug.