Bug 220510 – [ews] Add python 3 support - part 1

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Add Python 3 support to ews code.

[Aakash Jain]

Created attachment 417377 [details]
Patch

[EWS]

Committed r271361: <https://trac.webkit.org/changeset/271361>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417377 [details].

[Radar WebKit Bug Importer]

<rdar://problem/72999194>

[Alexey Proskuryakov]

Comment on attachment 417377 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417377&action=review

> Tools/ChangeLog:3
> +        [ews] Add python 3 support - part 1

This looks like moving to python 3 while dropping python 2, was this the intention?

> Tools/CISupport/ews-build/email_unittest.py:41
> -            self.assertTrue(category in emails.keys())
> +            self.assertTrue(category in list(emails.keys()))

Is this actually necessary? I think that converting to a list just makes the code slower.

> Tools/CISupport/ews-build/loadConfig_unittest.py:95
> +                    self.assertTrue(value[0] in list(schedulers_to_buildername_map.keys()),

Ditto.

[Aakash Jain]

Comment on attachment 417377 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417377&action=review

>> Tools/ChangeLog:3
>> +        [ews] Add python 3 support - part 1
> 
> This looks like moving to python 3 while dropping python 2, was this the intention?

The intention was to make the code compatible with both python 2 and 3.

>> Tools/CISupport/ews-build/email_unittest.py:41
>> +            self.assertTrue(category in list(emails.keys()))
> 
> Is this actually necessary? I think that converting to a list just makes the code slower.

Not really. It makes the 2to3 tool happy though.
This is a very small dictionary, and that too in unit-tests, the performance difference wouldn't really be noticeable in this case.

[Jonathan Bedard]

Comment on attachment 417377 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417377&action=review

>>> Tools/CISupport/ews-build/email_unittest.py:41
>>> +            self.assertTrue(category in list(emails.keys()))
>> 
>> Is this actually necessary? I think that converting to a list just makes the code slower.
> 
> Not really. It makes the 2to3 tool happy though.
> This is a very small dictionary, and that too in unit-tests, the performance difference wouldn't really be noticeable in this case.

No reason to do this here. The reason the 2to3 tool blindly does this is because in most operations, the difference matters. The exception is iteration and the 'in' operator.