| Summary: | Only import Python flatpak module on Linux | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||
| Component: | Tools / Tests | Assignee: | Don Olmstead <don.olmstead> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aperez, clopez, jbedard, pnormand, webkit-bug-importer, zdobersek | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 221815 | ||||||
| Attachments: |
|
||||||
|
Description
Don Olmstead
2021-02-23 11:38:35 PST
Created attachment 421341 [details]
Patch
Comment on attachment 421341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421341&action=review > Tools/Scripts/run-bindings-tests:-39 > -flatpakutils.run_in_sandbox_if_available(sys.argv) Looks like flatpakutils already centralizes the linux check...can we not fix this Windows problem there? Comment on attachment 421341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421341&action=review >> Tools/Scripts/run-bindings-tests:-39 >> -flatpakutils.run_in_sandbox_if_available(sys.argv) > > Looks like flatpakutils already centralizes the linux check...can we not fix this Windows problem there? I commented on the change that caused the issue at https://bugs.webkit.org/show_bug.cgi?id=222247#c4 which has the error. In this case it’s another issue of the signal library having differences between *nix and Windows. Honestly I think it’s safer in the long run for importing flatpack to be conditional on Linux since it’s really tied to that OS. Committed r273384: <https://commits.webkit.org/r273384> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421341 [details]. |