Bug 222274

Summary: REGRESSION(r273204): webkitpy tests don't run on Py3
Product: WebKit Reporter: Sam Sneddon [:gsnedders] <gsnedders>
Component: Tools / TestsAssignee: Sam Sneddon [:gsnedders] <gsnedders>
Status: RESOLVED FIXED    
Severity: Normal CC: jbedard, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=219641
Attachments:
Description Flags
Patch none

Sam Sneddon [:gsnedders]
Reported 2021-02-22 09:31:22 PST
gsnedders@gsnedders-milk py-bisect % ./Tools/Scripts/test-webkitpy Suppressing most webkitpy logging while running unit tests. Skipping tests in the following modules or packages because they are really, really, slow: webkitpy.common.checkout.scm.scm_unittest (https://bugs.webkit.org/show_bug.cgi?id=31818; use --all to include) Checking imports ...Failed to import webkit.messages_unittest: Failed to import webkit.messages_unittest: Traceback (most recent call last): Traceback (most recent call last): File "/Volumes/gsnedders/projects/Safari/py-bisect/Tools/Scripts/webkitpy/test/main.py", line 290, in _check_imports File "/Volumes/gsnedders/projects/Safari/py-bisect/Tools/Scripts/webkitpy/test/main.py", line 290, in _check_imports __import__(name) __import__(name) File "/Volumes/gsnedders/projects/Safari/py-bisect/Source/WebKit/Scripts/webkit/messages_unittest.py", line 36, in <module> File "/Volumes/gsnedders/projects/Safari/py-bisect/Source/WebKit/Scripts/webkit/messages_unittest.py", line 36, in <module> from webkit import messages, model, parser # noqa: E402 from webkit import messages, model, parser # noqa: E402 File "/Volumes/gsnedders/projects/Safari/py-bisect/Source/WebKit/Scripts/webkit/messages.py", line 27, in <module> File "/Volumes/gsnedders/projects/Safari/py-bisect/Source/WebKit/Scripts/webkit/messages.py", line 27, in <module> from model import MessageReceiver, Message from model import MessageReceiver, Message ModuleNotFoundError: No module named 'model' ModuleNotFoundError: No module named 'model'
Attachments
Patch (1.55 KB, patch)
2021-02-22 09:34 PST, Sam Sneddon [:gsnedders] 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1 2021-02-22 09:34:32 PST
Created attachment 421203 [details] Patch
EWS
Comment 2 2021-02-22 11:55:50 PST
Committed r273266: <https://commits.webkit.org/r273266> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421203 [details].
Radar WebKit Bug Importer
Comment 3 2021-02-22 11:56:13 PST
<rdar://problem/74607169>
Note You need to log in before you can comment on or make changes to this bug.