Bug 222263

Summary: Refactor OpenXR platform code into different classes and files.
Product: WebKit Reporter: Imanol Fernandez <ifernandez>
Component: WebXRAssignee: Imanol Fernandez <ifernandez>
Status: RESOLVED FIXED    
Severity: Normal CC: svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 208988, 222173    
Attachments:
Description Flags
Patch
none
Patch none

Imanol Fernandez
Reported 2021-02-22 02:23:21 PST
OpenXR port is going to grow with graphics, extensions, swapchains, controllers and more. We should split the code into different files to make it more readable and maintanable.
Attachments
Patch (48.29 KB, patch)
2021-02-22 02:36 PST, Imanol Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (53.71 KB, patch)
2021-02-22 09:28 PST, Imanol Fernandez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Imanol Fernandez
Comment 1 2021-02-22 02:36:16 PST
Created attachment 421175 [details] Patch
Sergio Villar Senin
Comment 2 2021-02-22 08:38:23 PST
Comment on attachment 421175 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421175&action=review Looking great. Perhaps add also the new files to XCode > Source/WebCore/ChangeLog:3 Super nit: OpenXR is not really a WebKit "port". It's just platform code. > Source/WebCore/ChangeLog:8 > + OpenXR port is going to grow with graphics, extensions, swapchains, controllers and more. Ditto > Source/WebCore/platform/xr/openxr/OpenXRExtensions.cpp:2 > + * Copyright (C) 2020 Igalia, S.L. 2021 :) > Source/WebCore/platform/xr/openxr/OpenXRInstance.cpp:2 > + * Copyright (C) 2020 Igalia, S.L. 2021
Imanol Fernandez
Comment 3 2021-02-22 09:28:47 PST
Created attachment 421201 [details] Patch Add files to Xcode and fix nits
EWS
Comment 4 2021-02-24 05:13:27 PST
Committed r273382: <https://commits.webkit.org/r273382> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421201 [details].
Radar WebKit Bug Importer
Comment 5 2021-02-24 05:14:14 PST
<rdar://problem/74691123>
Note You need to log in before you can comment on or make changes to this bug.