| Summary: | Refactor OpenXR platform code into different classes and files. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Imanol Fernandez <ifernandez> | ||||||
| Component: | WebXR | Assignee: | Imanol Fernandez <ifernandez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | svillar, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 208988, 222173 | ||||||||
| Attachments: |
|
||||||||
|
Description
Imanol Fernandez
2021-02-22 02:23:21 PST
Created attachment 421175 [details]
Patch
Comment on attachment 421175 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421175&action=review Looking great. Perhaps add also the new files to XCode > Source/WebCore/ChangeLog:3 Super nit: OpenXR is not really a WebKit "port". It's just platform code. > Source/WebCore/ChangeLog:8 > + OpenXR port is going to grow with graphics, extensions, swapchains, controllers and more. Ditto > Source/WebCore/platform/xr/openxr/OpenXRExtensions.cpp:2 > + * Copyright (C) 2020 Igalia, S.L. 2021 :) > Source/WebCore/platform/xr/openxr/OpenXRInstance.cpp:2 > + * Copyright (C) 2020 Igalia, S.L. 2021 Created attachment 421201 [details]
Patch
Add files to Xcode and fix nits
Committed r273382: <https://commits.webkit.org/r273382> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421201 [details]. |