Summary: | [Flatpak SDK] gdb unusable in sandbox | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
Component: | Tools / Tests | Assignee: | Philippe Normand <pnormand> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | annulen, calvaris, don.olmstead, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer, zan, zdobersek | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Philippe Normand
2021-02-21 04:14:36 PST
Created attachment 421138 [details]
Patch
Committed r273240 (234426@main): <https://commits.webkit.org/234426@main> This broke running test-webkitpy on Windows. python3 ./Tools/Scripts/test-webkitpy --verbose --buildbot-master build.webkit.org --builder-name WinCairo-64-bit-WKL-Release-Tests --build-number 214 --buildbot-worker wincairo-wkl-release-tests-01 --report https://results.webkit.org in dir C:\BW\wincairo-wkl-release-tests\build (timeout 1200 secs) watching logfiles {} argv: ['python3', './Tools/Scripts/test-webkitpy', '--verbose', '--buildbot-master', 'build.webkit.org', '--builder-name', 'WinCairo-64-bit-WKL-Release-Tests', '--build-number', '214', '--buildbot-worker', 'wincairo-wkl-release-tests-01', '--report', 'https://results.webkit.org'] using PTY: False Traceback (most recent call last): File "./Tools/Scripts/test-webkitpy", line 35, in <module> import flatpakutils File ".\Tools\flatpak\flatpakutils.py", line 399, in <module> def disable_signals(signals=[signal.SIGINT, signal.SIGTERM, signal.SIGHUP]): AttributeError: module 'signal' has no attribute 'SIGHUP' program finished with exit code 1 elapsedTime=1.213000 Please review https://bugs.webkit.org/show_bug.cgi?id=222327 which works around this change. Thanks! |