Bug 222117

Summary: REGRESSION (r273004): [ macOS ] media/modern-media-controls/volume-support/volume-support-drag.html is a flakey text failure
Product: WebKit Reporter: Robert Jenner <jenner>
Component: New BugsAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hi, jer.noble, philipj, sergio, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=222134
https://bugs.webkit.org/show_bug.cgi?id=222181
Attachments:
Description Flags
Update TestExpectations
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Robert Jenner
Reported 2021-02-18 10:44:29 PST
media/modern-media-controls/volume-support/volume-support-drag.html is a flakey text failure in macOS. HISTORY URL: https://results.webkit.org/?suite=layout-tests&test=media/modern-media-controls/volume-support/volume-support-drag.html DIFF URL: https://build.webkit.org/results/Apple-BigSur-Release-WK2-Tests/r273075%20(310)/media/modern-media-controls/volume-support/volume-support-drag-pretty-diff.html DIFF TEXT: @@ -6,19 +6,15 @@ By default, the volume slider should be set to 0 because the media is muted PASS mediaController.controls.volumeSlider.value is 0 PASS muteButton.getBoundingClientRect().width became different from 0 -PASS volumeSlider.getBoundingClientRect().width became different from 0 - -Before starting to drag the volume slider, the media should be muted still -PASS media.muted is true - -We initiated a volume slider drag, the media should no longer be muted and the volume set -PASS media.muted became false -PASS media.volume became 0.51 - -We finished dragging to set the volume to 1 -PASS media.volume became 1 -PASS mediaController.controls.volumeSlider.parent.visible is true PASS successfullyParsed is true TEST COMPLETE + + + + +0:00 + +0:06 + Have not reproduced yet. However, history points to flakey failures starting at r273004. There do appear to be related changes at that revision.
Attachments
Update TestExpectations (2.42 KB, patch)
2021-02-18 15:25 PST, Robert Jenner 		no flags
DetailsFormatted DiffDiff
Patch (3.21 KB, patch)
2021-02-23 16:08 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (3.25 KB, patch)
2021-02-23 17:10 PST, Devin Rousso 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (3.24 KB, patch)
2021-02-23 17:12 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-02-18 10:44:46 PST
<rdar://problem/74484639>
Robert Jenner
Comment 2 2021-02-18 11:46:28 PST
Reproduced failure at tip of tree, and by reverting checkout to r273004, and running test: run-webkit-test media/modern-media-controls/volume-support/volume-support-drag.html --iterations 100 -f Ran same test at r273003 checkout, and the failure was not reproducible.
Robert Jenner
Comment 3 2021-02-18 15:04:20 PST
media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-fullscreen.html Is a similar test that is failing at the same regression point.
Robert Jenner
Comment 4 2021-02-18 15:25:25 PST
Created attachment 420879 [details] Update TestExpectations
Truitt Savell
Comment 5 2021-02-18 15:28:35 PST
Comment on attachment 420879 [details] Update TestExpectations Clearing flags on attachment: 420879 Committed r273105 (234303@main): <https://commits.webkit.org/234303@main>
Devin Rousso
Comment 6 2021-02-23 16:08:07 PST
Created attachment 421364 [details] Patch
Devin Rousso
Comment 7 2021-02-23 17:10:13 PST
Created attachment 421373 [details] Patch
EWS
Comment 8 2021-02-23 17:11:06 PST
/Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Devin Rousso
Comment 9 2021-02-23 17:12:10 PST
Created attachment 421375 [details] Patch
EWS
Comment 10 2021-02-23 17:41:36 PST
Committed r273366: <https://commits.webkit.org/r273366> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421375 [details].
Note You need to log in before you can comment on or make changes to this bug.